From: Stephen Warren <swarren@wwwdotorg.org>
To: bardliao@realtek.com
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
swarren@nvidia.com, lgirdwood@gmail.com, broonie@kernel.org,
flove@realtek.com
Subject: Re: [PATCH V3] ASoC: rt5640: change widget sequence for depop
Date: Fri, 23 Aug 2013 10:26:51 -0600 [thread overview]
Message-ID: <52178D4B.1040101@wwwdotorg.org> (raw)
In-Reply-To: <52178970.2080406@wwwdotorg.org>
On 08/23/2013 10:10 AM, Stephen Warren wrote:
> On 08/22/2013 08:29 PM, bardliao@realtek.com wrote:
>> From: Bard Liao <bardliao@realtek.com>
>
> A patch description might be useful?
>
> Tested-by: Stephen Warren <swarren@nvidia.com>
Oh, but remember that this patch depends on the following from
Lars-Peter that hasn't yet been posted, so this patch shouldn't be
applied until that one is, or it'll break things horribly:
diff --git a/sound/soc/soc-dapm.c b/sound/soc/soc-dapm.c
index d84bd0f..2ed1dcd 100644
--- a/sound/soc/soc-dapm.c
+++ b/sound/soc/soc-dapm.c
@@ -229,6 +229,8 @@ static int dapm_kcontrol_data_alloc(struct
snd_soc_dapm_widget *widget,
template.id = snd_soc_dapm_kcontrol;
template.name = kcontrol->id.name;
+ data->value = template.on_val;
+
data->widget =
snd_soc_dapm_new_control(widget->dapm,
&template);
if (!data->widget) {
next prev parent reply other threads:[~2013-08-23 16:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-23 2:29 [PATCH V3] ASoC: rt5640: change widget sequence for depop bardliao
2013-08-23 16:10 ` Stephen Warren
2013-08-23 16:26 ` Stephen Warren [this message]
2013-08-23 16:45 ` Mark Brown
2013-08-23 16:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52178D4B.1040101@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=flove@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=swarren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).