alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Andrew Lunn <andrew@lunn.ch>,
	alsa-devel@alsa-project.org, Jason Cooper <jason@lakedaemon.net>,
	Jean-Francois Moine <moinejf@free.fr>,
	Takashi Iwai <tiwai@suse.de>, Liam Girdwood <lgirdwood@gmail.com>,
	Mark Brown <broonie@kernel.org>,
	linux-arm-kernel@lists.infradead.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 00/14] SPDIF support
Date: Sat, 31 Aug 2013 17:28:26 +0200	[thread overview]
Message-ID: <52220B9A.9000007@metafoo.de> (raw)
In-Reply-To: <20130831123458.GF6617@n2100.arm.linux.org.uk>

On 08/31/2013 02:34 PM, Russell King - ARM Linux wrote:
[...]
> The same conditions apply as per my previous posting - the DAI link
> needs to be setup and the associated DAPM routes to tell the CPU DAI
> which outputs are in use, like this:
> 
> DAI link:
>                 .name = "S/PDIF1",
>                 .stream_name = "IEC958 Playback",
>                 .platform_name = "mvebu-audio.1",
>                 .cpu_dai_name = "mvebu-audio.1",
>                 .codec_dai_name = "dit-hifi",
>                 .codec_name = "spdif-dit",
> 
> static const struct snd_soc_dapm_route routes[] = {
>         { "Playback", NULL, "spdifdo" },
> };

This is still not exactly the right way to implement this though. Add a
second DAI to your CPU driver, like this:

static struct snd_soc_dai_driver kirkwood_mvebu_dais[] = {
	{
		.id = 0,
		.probe = kirkwood_i2s_probe,
    		.playback = {
			.stream_name = "I2S Capture",
			...
		},
		.capture = {
			.stream_name = "I2S Playback",
			...
		},
		.ops = &kirkwood_i2s_dai_ops,
	}, {
		.id = 1,
		.probe = kirkwood_i2s_probe,
    		.playback = {
			.stream_name = "SPDIF Capture",
			...
		},
		.capture = {
			.stream_name = "SPDIF Playback",
			...
		},
		.ops = &kirkwood_i2s_dai_ops,
	},
};

Then connect the SPDIF AIF widgets to the SPDIF streams and the I2S AIF
widgets to the I2S streams. In your machine driver setup the link config to
use DAI 0 if the board uses I2S and DAI 1 if the board uses SPDIF. The ASoC
framework will then create the necessary routes all by itself. Of course
this won't work on a platform where both the SPDIF and I2S controller are
used at the same time, but neither does your current solution.

- Lars

  parent reply	other threads:[~2013-08-31 15:26 UTC|newest]

Thread overview: 58+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-31 12:34 [PATCH 00/14] SPDIF support Russell King - ARM Linux
2013-08-31 12:35 ` [PATCH 01/14] ASoC: kirkwood: merge struct kirkwood_dma_priv with struct kirkwood_dma_data Russell King
2013-08-31 12:36 ` [PATCH 02/14] ASoC: kirkwood: use devm_clk_get() for the external clock Russell King
2013-08-31 12:37 ` [PATCH 03/14] ASoC: avoid duplicated DAI routes Russell King
2013-08-31 12:38 ` [PATCH 04/14] ASoC: kirkwood: provide KIRKWOOD_PLAYCTL_ENABLE_MASK Russell King
2013-08-31 12:39 ` [PATCH 05/14] ASoC: kirkwood: combine kirkwood-i2s and kirkwood-dma drivers Russell King
2013-08-31 12:40 ` [PATCH 06/14] ASoC: kirkwood: move calculation of max buffer size to kirkwood.h Russell King
2013-08-31 12:41 ` [PATCH 07/14] ASoC: spdif_transceiver: add output pin widget Russell King
2013-08-31 12:42 ` [PATCH 08/14] ASoC: kirkwood: prefer external clock over internal clock Russell King
2013-09-01 16:41   ` Jean-Francois Moine
2013-09-02 11:01     ` Mark Brown
2013-09-02 14:17       ` Russell King - ARM Linux
2013-08-31 12:43 ` [PATCH 09/14] ASoC: kirkwood-dma: remove IEC958_SUBFRAME formats Russell King
2013-09-02 11:02   ` Mark Brown
2013-08-31 12:44 ` [PATCH 10/14] ASoC: kirkwood: add DAPM widgets for input and output routing Russell King
2013-08-31 12:45 ` [PATCH 11/14] ASoC: kirkwood-openrd: add DAPM links between codec and cpu DAI Russell King
2013-08-31 12:46 ` [PATCH 12/14] ASoC: kirkwood-t5325: " Russell King
2013-08-31 12:47 ` [PATCH 13/14] ASoC: kirkwood: add SPDIF output support Russell King
2013-09-03 11:17   ` Mark Brown
2013-09-03 11:38     ` Russell King - ARM Linux
2013-09-03 11:59       ` Mark Brown
2013-09-03 13:34         ` Russell King - ARM Linux
2013-09-04 16:34           ` Mark Brown
2013-08-31 12:48 ` [PATCH 14/14] ASoC: kirkwood: add IEC958 channel status support Russell King
2013-08-31 15:28 ` Lars-Peter Clausen [this message]
2013-08-31 17:28   ` [PATCH 00/14] SPDIF support Mark Brown
2013-08-31 19:19     ` [alsa-devel] " Russell King - ARM Linux
2013-08-31 20:46       ` Lars-Peter Clausen
2013-08-31 21:05         ` Russell King - ARM Linux
2013-08-31 22:23           ` Russell King - ARM Linux
2013-09-01 12:19           ` Mark Brown
2013-09-01 12:34             ` Russell King - ARM Linux
2013-09-01 13:02               ` Russell King - ARM Linux
2013-09-02 14:06               ` Mark Brown
2013-09-02 14:16                 ` Russell King - ARM Linux
2013-09-02 16:27                   ` Mark Brown
2013-09-02 16:59                     ` Russell King - ARM Linux
2013-09-02 20:44                       ` Mark Brown
2013-09-02 21:18                         ` Russell King - ARM Linux
2013-09-02 22:35                           ` Mark Brown
2013-09-02 23:00                             ` Russell King - ARM Linux
2013-09-04 19:33                               ` Mark Brown
2013-09-01  6:42         ` Russell King - ARM Linux
2013-09-01  7:42           ` [alsa-devel] " Lars-Peter Clausen
2013-09-01  8:51             ` Russell King - ARM Linux
2013-09-01 10:08               ` Lars-Peter Clausen
2013-09-01 12:04                 ` Russell King - ARM Linux
2013-09-01 17:32                   ` Lars-Peter Clausen
2013-09-01 11:51               ` Mark Brown
2013-09-01 12:15                 ` Russell King - ARM Linux
2013-09-01 17:05                   ` Mark Brown
2013-08-31 19:14   ` Russell King - ARM Linux
2013-08-31 19:34     ` Russell King - ARM Linux
2013-09-02 14:47       ` Mark Brown
2013-09-02 14:52         ` Russell King - ARM Linux
2013-09-02 14:57           ` Russell King - ARM Linux
2013-09-02 16:41             ` Mark Brown
2013-08-31 20:45     ` Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52220B9A.9000007@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=andrew@lunn.ch \
    --cc=broonie@kernel.org \
    --cc=jason@lakedaemon.net \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux@arm.linux.org.uk \
    --cc=moinejf@free.fr \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).