From: Daniel Mack <zonque@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, guido.aulisi@gmail.com,
nicholas.bailey@glasgow.ac.uk
Subject: Re: [PATCH] ALSA: snd-usb-usx2y: remove bogus frame check
Date: Wed, 02 Oct 2013 17:49:29 +0200 [thread overview]
Message-ID: <524C4089.4070704@gmail.com> (raw)
In-Reply-To: <s5ha9iru1a3.wl%tiwai@suse.de>
On 02.10.2013 17:43, Takashi Iwai wrote:
> At Wed, 2 Oct 2013 15:54:28 +0200,
> Daniel Mack wrote:
>>
>> The frame check in i_usX2Y_urb_complete() is bogus and produces false
>> positives as described in this LAU thread:
>>
>> http://linuxaudio.org/mailarchive/lau/2013/5/20/200177
>>
>> This code removes the check code entirely.
>>
>> Cc: fzu@wemgehoertderstaat.de
>> Reported-by: Dr Nicholas J Bailey <nicholas.bailey@glasgow.ac.uk>
>> Suggested-by: Takashi Iwai <tiwai@suse.de>
>> Signed-off-by: Daniel Mack <zonque@gmail.com>
>
> It's referred in usx2yhwdeppcm.c, too (the file is included there).
Eek. I missed that. Thanks for the heads-up.
> Yeah, I know that the driver code is fairly complex (IOW ugly). IIRC,
> the hwdeppcm mmap is also broken, and we need yet another fix.
> Sigh...
I don't know if Karsten (cc) is still maintaning this piece of code :-/
Daniel
prev parent reply other threads:[~2013-10-02 15:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 13:54 [PATCH] ALSA: snd-usb-usx2y: remove bogus frame check Daniel Mack
2013-10-02 15:43 ` Takashi Iwai
2013-10-02 15:49 ` Daniel Mack [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=524C4089.4070704@gmail.com \
--to=zonque@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=guido.aulisi@gmail.com \
--cc=nicholas.bailey@glasgow.ac.uk \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).