From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jarkko Nikula Subject: Re: [RFC] ASoC: core: Allow DAI links to be specified by using ACPI names Date: Fri, 04 Oct 2013 10:22:43 +0300 Message-ID: <524E6CC3.8040507@linux.intel.com> References: <1380803636-24079-1-git-send-email-jarkko.nikula@linux.intel.com> <1655137.c5uTBo1XRy@vostro.rjw.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1655137.c5uTBo1XRy@vostro.rjw.lan> Sender: linux-acpi-owner@vger.kernel.org To: "Rafael J. Wysocki" Cc: alsa-devel@alsa-project.org, linux-acpi@vger.kernel.org, Mark Brown , Liam Girdwood , Mika Westerberg List-Id: alsa-devel@alsa-project.org On 10/04/2013 09:53 AM, Rafael J. Wysocki wrote: > On Thursday, October 03, 2013 03:33:56 PM Jarkko Nikula wrote: >> This patch adds alternative way to specify DAI links by using ACPI names. >> ACPI name here is considered to be used as an alias for device name during >> DAI link binding time. > What's DAI? It comes from Digital Audio Interface, and DAI link in ALSA SoC basically ties together platform, DAI and codec devices by name or device tree node. > +#if IS_ENABLED(CONFIG_ACPI) > That's not necessary, because ACPI_HANDLE() is defined as false for > CONFIG_ACPI unset. Actually problem acpi_bus_get_device() that is not available if CONFIG_ACPI is not set. Which suggests was it even meant to be used in drivers that are build for non ACPI systems too? -- Jarkko