From: Clemens Ladisch <clemens@ladisch.de>
To: Eldad Zack <eldad@fogrefinery.com>
Cc: Takashi Iwai <tiwai@suse.de>,
Nikolay Martynov <mar.kolya@gmail.com>,
alsa-devel@alsa-project.org, Daniel Mack <zonque@gmail.com>
Subject: Re: [PATCH v4 09/15] ALSA: usb-audio: conditional interface altsetting
Date: Mon, 07 Oct 2013 20:23:38 +0200 [thread overview]
Message-ID: <5252FC2A.306@ladisch.de> (raw)
In-Reply-To: <alpine.LNX.2.00.1310071920480.1353@anubis>
Eldad Zack wrote:
> On Mon, 7 Oct 2013, Takashi Iwai wrote:
>> Eldad Zack wrote:
>>> On some devices, if the endpoint for the other direction is in use,
>>> setting one interface will shutdown the other (in use) endpoint.
>>> This patch moves all of the alternate setting operations for pcm
>>> ops to one function which checks if we can do so.
>>>
>>> If current alternate is 0, it is safe to set.
>>
>> Is this check needed for all devices?
>
> I'm not sure, I only have this one device to test with.
In theory, interfaces are independent, but in practice, the firmware
does whatever it does. For implicit feedback devices, it's likely that
they were expected to be used in full duplex mode only.
Regards,
Clemens
next prev parent reply other threads:[~2013-10-07 18:23 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-06 20:31 [PATCH v4 00/15] ALSA: usb-audio: fix playback/capture concurrent usage Eldad Zack
2013-10-06 20:31 ` [PATCH v4 01/15] ALSA: usb-audio: remove unused parameter from sync_ep_set_params Eldad Zack
2013-10-06 20:31 ` [PATCH v4 02/15] ALSA: usb-audio: remove deactivate_endpoints() Eldad Zack
2013-10-06 20:31 ` [PATCH v4 03/15] ALSA: usb-audio: prevent NULL dereference on stop trigger Eldad Zack
2013-10-07 8:57 ` Takashi Iwai
2013-10-06 20:31 ` [PATCH v4 04/15] ALSA: usb-audio: don't deactivate URBs on in-use EP Eldad Zack
2013-10-06 20:31 ` [PATCH v4 05/15] ALSA: usb-audio: void return type of snd_usb_endpoint_deactivate() Eldad Zack
2013-10-06 20:31 ` [PATCH v4 06/15] ALSA: usb-audio: clear SUBSTREAM_FLAG_SYNC_EP_STARTED on error Eldad Zack
2013-10-06 20:31 ` [PATCH v4 07/15] ALSA: usb-audio: correct ep use_count semantics (add set_param flag) Eldad Zack
2013-10-07 9:21 ` Takashi Iwai
2013-10-07 19:31 ` Eldad Zack
2013-10-08 7:01 ` Takashi Iwai
2013-10-06 20:31 ` [PATCH v4 08/15] ALSA: usb-audio: rename alt_idx to altsetting Eldad Zack
2013-10-06 20:31 ` [PATCH v4 09/15] ALSA: usb-audio: conditional interface altsetting Eldad Zack
2013-10-07 10:34 ` Takashi Iwai
2013-10-07 18:00 ` Eldad Zack
2013-10-07 18:23 ` Clemens Ladisch [this message]
2013-10-07 19:31 ` Takashi Iwai
2013-10-06 20:31 ` [PATCH v4 10/15] ALSA: usb-audio: conditional concurrent usage of endpoint Eldad Zack
2013-10-06 20:31 ` [PATCH v4 11/15] ALSA: usb-audio: remove altset_idx from snd_usb_substream Eldad Zack
2013-10-06 20:31 ` [PATCH v4 12/15] ALSA: usb-audio: remove unused endpoint flag EP_FLAG_ACTIVATED Eldad Zack
2013-10-06 20:31 ` [PATCH v4 13/15] ALSA: usb-audio: clear sync subs hw_params Eldad Zack
2013-10-06 20:31 ` [PATCH v4 14/15] ALSA: usb-audio: always wait in start_endpoints Eldad Zack
2013-10-07 9:26 ` Takashi Iwai
2013-10-07 19:26 ` Eldad Zack
2013-10-08 7:05 ` Takashi Iwai
2013-10-08 19:25 ` Eldad Zack
2013-10-06 20:31 ` [PATCH v4 15/15] ALSA: usb-audio: improve logging messages Eldad Zack
2013-10-07 9:23 ` Takashi Iwai
2013-10-07 9:30 ` [PATCH v4 00/15] ALSA: usb-audio: fix playback/capture concurrent usage Takashi Iwai
2013-10-07 17:20 ` Eldad Zack
2013-10-28 17:45 ` Nikolay Martynov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5252FC2A.306@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=eldad@fogrefinery.com \
--cc=mar.kolya@gmail.com \
--cc=tiwai@suse.de \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).