From: Lars-Peter Clausen <lars@metafoo.de>
To: Wolfram Sang <wsa@the-dreams.de>
Cc: alsa-devel@alsa-project.org,
Sascha Hauer <s.hauer@pengutronix.de>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Markus Pargmann <mpa@pengutronix.de>,
Shawn Guo <shawn.guo@linaro.org>
Subject: Re: [PATCH] sound/soc/fsl: remove leftover release_mem_region
Date: Sun, 13 Oct 2013 20:36:59 +0200 [thread overview]
Message-ID: <525AE84B.8080703@metafoo.de> (raw)
In-Reply-To: <1381685916-7401-1-git-send-email-wsa@the-dreams.de>
On 10/13/2013 07:38 PM, Wolfram Sang wrote:
> When converting this driver to devm_ioremap_resource, the removal of this now
> unneeded function has been forgotten.
>
> Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
> ---
> sound/soc/fsl/imx-ssi.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/sound/soc/fsl/imx-ssi.c b/sound/soc/fsl/imx-ssi.c
> index f58bcd8..b2cc743 100644
> --- a/sound/soc/fsl/imx-ssi.c
> +++ b/sound/soc/fsl/imx-ssi.c
> @@ -615,7 +615,6 @@ failed_pcm_dma:
> failed_pcm_fiq:
> snd_soc_unregister_component(&pdev->dev);
> failed_register:
> - release_mem_region(res->start, resource_size(res));
> clk_disable_unprepare(ssi->clk);
> failed_clk:
> snd_soc_set_ac97_ops(NULL);
> @@ -636,7 +635,6 @@ static int imx_ssi_remove(struct platform_device *pdev)
> if (ssi->flags & IMX_SSI_USE_AC97)
> ac97_ssi = NULL;
>
> - release_mem_region(res->start, resource_size(res));
This should trigger a warning about res being unused now.
> clk_disable_unprepare(ssi->clk);
> snd_soc_set_ac97_ops(NULL);
>
>
prev parent reply other threads:[~2013-10-13 18:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-13 17:38 [PATCH] sound/soc/fsl: remove leftover release_mem_region Wolfram Sang
2013-10-13 18:36 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=525AE84B.8080703@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=mpa@pengutronix.de \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@linaro.org \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).