From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Mark Brown <broonie@linaro.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Ryan Mallon <rmallon@gmail.com>
Subject: Re: [PATCH 2/2] ASoC: ep93xx: Open code dma channel request
Date: Sat, 19 Oct 2013 19:19:41 +0200 [thread overview]
Message-ID: <5262BF2D.1080104@metafoo.de> (raw)
In-Reply-To: <1382188384-18063-2-git-send-email-broonie@kernel.org>
On 10/19/2013 03:13 PM, Mark Brown wrote:
[...]
> static const struct snd_dmaengine_pcm_config ep93xx_dmaengine_pcm_config = {
> .pcm_hardware = &ep93xx_pcm_hardware,
> .compat_filter_fn = ep93xx_pcm_dma_filter,
The compat_filter_fn attribute should probably removed
> + .compat_request_channel = ep93xx_compat_request_channel,
> .prealloc_buffer_size = 131072,
> };
Otherwise it looks fine
next prev parent reply other threads:[~2013-10-19 17:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 13:13 [PATCH 1/2] ASoC: cirrus: Enable compile test builds Mark Brown
2013-10-19 13:13 ` [PATCH 2/2] ASoC: ep93xx: Open code dma channel request Mark Brown
2013-10-19 17:19 ` Lars-Peter Clausen [this message]
2013-10-19 20:00 ` Mark Brown
2013-10-22 12:05 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5262BF2D.1080104@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).