From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, linaro-kernel@lists.linaro.org,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH] ASoC: dmaengine: Use filter_data rather than dma_data for compat requests
Date: Sat, 19 Oct 2013 19:22:17 +0200 [thread overview]
Message-ID: <5262BFC9.3020405@metafoo.de> (raw)
In-Reply-To: <1382189739-22732-1-git-send-email-broonie@kernel.org>
On 10/19/2013 03:35 PM, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> When using the legacy filter function channel requests we currently pass
> the audio specific struct snd_dmaengine_dai_dma_data which isn't likely to
> be helpful for actual filtering. Since there's already a field in the
> structure called filter_data clearly intended for use here convert the
> driver to use that.
>
> All existing users of plain filter functions have been converted to use
> an explict compat function to override this behaviour.
I think this patch also needs to update sound/soc/fsl/imx-pcm-dma.c
next prev parent reply other threads:[~2013-10-19 17:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 13:35 [PATCH] ASoC: dmaengine: Use filter_data rather than dma_data for compat requests Mark Brown
2013-10-19 17:22 ` Lars-Peter Clausen [this message]
2013-10-19 20:01 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2013-10-19 20:38 Mark Brown
2013-10-21 1:03 ` Shawn Guo
2013-10-22 11:30 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5262BFC9.3020405@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).