alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
To: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
Cc: Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Thierry Reding
	<thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org,
	Mark Brown <broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Subject: Re: [alsa-devel] [PATCH] ASoC: tegra: Remove redundant initialisation of compat_filter_fn
Date: Tue, 22 Oct 2013 13:40:18 +0200	[thread overview]
Message-ID: <52666422.9010505@metafoo.de> (raw)
In-Reply-To: <52644D3C.9020709-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>

On 10/20/2013 11:38 PM, Stephen Warren wrote:
> On 10/19/2013 02:17 PM, Mark Brown wrote:
>> From: Mark Brown <broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
>>
>> Setting a field in a static struct to NULL has no effect so don't bother
>> (and don't generate false positives for grep).
> 
> I'm fine with this either way, so feel free to take my ack whichever way
> you work this out with Lars-Peter.

I don't care that much either, just wanted to give an explanation why things
are the way they are. Mark, if you want to merge this patch you can add:
Acked-by: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>

Btw. wasn't there a plan to move tegra to the generic dma bindings? If not I
think it might be a good idea to add the possibility to let the DMA  driver
overwrite the DT attribute parsing done by of_dma_match_channel(). This
would spare drivers from having to do the parsing manually and it would
allow the tegra pcm driver to just follow the normal OF path in the
generic-dmaengine-pcm driver and didn't had to rely on the compat path.

- Lars

  parent reply	other threads:[~2013-10-22 11:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-10-19 13:17 [PATCH] ASoC: tegra: Remove redundant initialisation of compat_filter_fn Mark Brown
2013-10-19 17:26 ` Lars-Peter Clausen
     [not found] ` <1382188623-19494-1-git-send-email-broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-10-20 21:38   ` Stephen Warren
     [not found]     ` <52644D3C.9020709-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
2013-10-22 11:40       ` Lars-Peter Clausen [this message]
     [not found]         ` <52666422.9010505-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2013-10-22 21:07           ` [alsa-devel] " Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52666422.9010505@metafoo.de \
    --to=lars-qo5elluwu/uelga04laivw@public.gmane.org \
    --cc=alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org \
    --cc=broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=broonie-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
    --cc=linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org \
    --cc=thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).