From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: Kukjin Kim <kgene.kim@samsung.com>,
Sangbeom Kim <sbkim73@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Tomasz Figa <t.figa@samsung.com>,
alsa-devel@alsa-project.org, linux-samsung-soc@vger.kernel.org,
linaro-kernel@lists.linaro.org, Mark Brown <broonie@linaro.org>
Subject: Re: [alsa-devel] [PATCH 2/3] ASoC: dmaengine: Support custom channel names
Date: Tue, 22 Oct 2013 13:45:17 +0200 [thread overview]
Message-ID: <5266654D.30200@metafoo.de> (raw)
In-Reply-To: <1382201032-13538-2-git-send-email-broonie@kernel.org>
On 10/19/2013 06:43 PM, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> Some devices have more than just simple TX and RX DMA channels, for example
> modern Samsung I2S IPs support a secondary transmit DMA stream which is
> mixed into the primary stream during playback. Allow such devices to
> specify the names of the channels to be requested in their dma_data.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
As shortly discussed yesterday, I think the general idea is fine. But it
might be better to have the names available at PCM creation time, since this
allows us to e.g. do proper probe referral and will also have the code take
the same path in the DT case, no matter if it uses the default names or not.
- Lars
next prev parent reply other threads:[~2013-10-22 11:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 16:43 [PATCH 1/3] ASoC: samsung: Provide helper for DMA init Mark Brown
2013-10-19 16:43 ` [PATCH 2/3] ASoC: dmaengine: Support custom channel names Mark Brown
2013-10-22 11:45 ` Lars-Peter Clausen [this message]
2013-10-23 11:30 ` Mark Brown
2013-10-23 13:32 ` [alsa-devel] " Lars-Peter Clausen
2013-10-19 16:43 ` [PATCH 3/3] ASoC: samsung: Use ASoC dmaengine code where possible Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5266654D.30200@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=kgene.kim@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sbkim73@samsung.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).