From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Ryan Mallon <rmallon@gmail.com>
Subject: Re: [PATCH 2/2] ASoC: ep93xx: Open code dma channel request
Date: Tue, 22 Oct 2013 14:05:37 +0200 [thread overview]
Message-ID: <52666A11.6000401@metafoo.de> (raw)
In-Reply-To: <20131019200032.GD2443@sirena.org.uk>
On 10/19/2013 10:00 PM, Mark Brown wrote:
> On Sat, Oct 19, 2013 at 07:19:41PM +0200, Lars-Peter Clausen wrote:
>> On 10/19/2013 03:13 PM, Mark Brown wrote:
>> [...]
>>> static const struct snd_dmaengine_pcm_config ep93xx_dmaengine_pcm_config = {
>>> .pcm_hardware = &ep93xx_pcm_hardware,
>>> .compat_filter_fn = ep93xx_pcm_dma_filter,
>
>> The compat_filter_fn attribute should probably removed
>
> Yeah, I was in two minds about that. Obviously the ideal thing is to
> change the drivers so they can use the filter function again; from that
> point of view it's kind of like what's going on with Tegra in intention
> - it is notionaly using the filter function, it's just that the DAIs are
> putting the data in the wrong place at the minute.
Ok.
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
prev parent reply other threads:[~2013-10-22 12:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-19 13:13 [PATCH 1/2] ASoC: cirrus: Enable compile test builds Mark Brown
2013-10-19 13:13 ` [PATCH 2/2] ASoC: ep93xx: Open code dma channel request Mark Brown
2013-10-19 17:19 ` Lars-Peter Clausen
2013-10-19 20:00 ` Mark Brown
2013-10-22 12:05 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52666A11.6000401@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=rmallon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).