From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [alsa-devel] [PATCH] ASoC: tegra: Remove redundant initialisation of compat_filter_fn Date: Tue, 22 Oct 2013 22:07:05 +0100 Message-ID: <5266E8F9.70307@wwwdotorg.org> References: <1382188623-19494-1-git-send-email-broonie@kernel.org> <52644D3C.9020709@wwwdotorg.org> <52666422.9010505@metafoo.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <52666422.9010505-Qo5EllUWu/uELgA04lAiVw@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Lars-Peter Clausen Cc: Mark Brown , Thierry Reding , linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, Mark Brown List-Id: alsa-devel@alsa-project.org On 10/22/2013 12:40 PM, Lars-Peter Clausen wrote: > On 10/20/2013 11:38 PM, Stephen Warren wrote: >> On 10/19/2013 02:17 PM, Mark Brown wrote: >>> From: Mark Brown >>> >>> Setting a field in a static struct to NULL has no effect so don't bother >>> (and don't generate false positives for grep). >> >> I'm fine with this either way, so feel free to take my ack whichever way >> you work this out with Lars-Peter. > > I don't care that much either, just wanted to give an explanation why things > are the way they are. Mark, if you want to merge this patch you can add: > Acked-by: Lars-Peter Clausen > > Btw. wasn't there a plan to move tegra to the generic dma bindings? IIRC, it's been using them for a release or two.