From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
Michal Bachraty <michal.bachraty@streamunlimited.com>,
nsekhar@ti.com, Liam Girdwood <lgirdwood@gmail.com>,
jsarha@ti.com, Daniel Mack <zonque@gmail.com>,
gururaja.hebbar@ti.com
Subject: Re: [PATCH 19/20] ASoC: davinci-mcasp: Support for fck reparenting
Date: Thu, 14 Nov 2013 14:59:19 +0200 [thread overview]
Message-ID: <5284C927.2040404@ti.com> (raw)
In-Reply-To: <20131114115110.GH26614@sirena.org.uk>
On 11/14/2013 01:51 PM, Mark Brown wrote:
> On Thu, Nov 14, 2013 at 11:35:35AM +0200, Peter Ujfalusi wrote:
>
>> +- fck_parent : Should contain a valid clock name which will be used as parent
>> + for the McASP fck
>
> I'd expect this to be specified using standard clock tree bindings?
As of now we do not have (AM33xx/AM43xx/DRA7xx) clocks in DT so the standard
clock tree bindings can not be added (no phandle to link).
In arch OMAP we have another issue coming from legacy: omap-hwmod will treat
the standard clock bindings as optional clocks and when the device got enabled
it enables the main fck and also the optional clocks. This will not cause big
issue at the end, but the prepare/enable count for the parent clock will be
doubled. fck enable will enable the branch (including parent) and the
omap-hwmod code will enable the optional clocks, which includes the parent
clock :o
For now I would keep the parent clock name and when we have the standard clock
bindings ready I can switch to use to that.
--
Péter
next prev parent reply other threads:[~2013-11-14 12:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-14 9:35 [PATCH 00/21] ASoC: davinci: Code cleanups and support for DRA7xx Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 01/20] ASoC: davinci: Kconfig: Remove help section for SND_DAVINCI_SOC Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 02/20] ASoC: davinci: Kconfig/Makefile: Generic EVM machine driver related cleanup Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 03/20] ASoC: davinci: kconfig: Prepare for AM43xx support Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 04/20] ASoC: davinci-evm: Do not include davinci-mcasp.h Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 05/20] ASoC: davinci-evm: Switch to use .dai_fmt of snd_soc_dai_link(s) Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 06/20] ASoC: davinci-mcasp: Move DAVINCI_MCASP_RATE from header to source file Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 07/20] ASoC: davinci-mcasp: Remove unused DAVINCI_MCASP_I2S/DIT_DAI defines Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 08/20] ASoC: davinci-mcasp: Correct dai driver struct initialization for 2nd dai Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 09/20] ASoC: davinci-mcasp: Move register definitions to header file Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 10/20] ASoC: davinci-mcasp: Move private struct definition to source file Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 11/20] ASoC: davinci-mcasp: Remove unused DAVINCI_MCASP_NUM_SERIALIZER define Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 12/20] ASoC: davinci-mcasp: Do not inline the mcasp_set_ctl_reg function Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 13/20] ASoC: davinci-mcasp: Rename private struct and it's users (dev -> mcasp) Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 14/20] ASoC: davinci-mcasp: Be consistent with the use of base in davinci_mcasp_set_dai_fmt Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 15/20] ASoC: davinci-mcasp: Simplify FIFO configuration code Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 16/20] ASoC: davinci-mcasp: Data source (bus) selection support Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 17/20] ASoC: davinci-mcasp: Fix synchronous master receive mode Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 18/20] ASoC: davinci-mcasp: Support for McASP version found in DRA7xx Peter Ujfalusi
2013-11-14 9:35 ` [PATCH 19/20] ASoC: davinci-mcasp: Support for fck reparenting Peter Ujfalusi
2013-11-14 11:51 ` Mark Brown
2013-11-14 12:59 ` Peter Ujfalusi [this message]
2013-11-14 9:35 ` [PATCH 20/20] ASoC: davinci-mcasp: Change IO functions parameter list Peter Ujfalusi
2013-11-14 11:54 ` Mark Brown
2013-11-14 9:35 ` [PATCH 21/21] ASoC: davinci-mcasp: Correct am33xx snd_platform_data name Peter Ujfalusi
2013-11-14 11:55 ` Mark Brown
2013-11-14 11:52 ` [PATCH 00/21] ASoC: davinci: Code cleanups and support for DRA7xx Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5284C927.2040404@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gururaja.hebbar@ti.com \
--cc=jsarha@ti.com \
--cc=lgirdwood@gmail.com \
--cc=michal.bachraty@streamunlimited.com \
--cc=nsekhar@ti.com \
--cc=zonque@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).