From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH V2 2/3] ASoC: don't leak on error in snd_dmaengine_pcm_register Date: Fri, 06 Dec 2013 10:30:38 +0100 Message-ID: <52A1993E.8050109@metafoo.de> References: <1386105994-16373-1-git-send-email-swarren@wwwdotorg.org> <1386105994-16373-2-git-send-email-swarren@wwwdotorg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-out-151.synserver.de (smtp-out-158.synserver.de [212.40.185.158]) by alsa0.perex.cz (Postfix) with ESMTP id 934B5261ADF for ; Fri, 6 Dec 2013 10:29:58 +0100 (CET) In-Reply-To: <1386105994-16373-2-git-send-email-swarren@wwwdotorg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Stephen Warren Cc: alsa-devel@alsa-project.org, Mark Brown , Stephen Warren , Liam Girdwood List-Id: alsa-devel@alsa-project.org On 12/03/2013 10:26 PM, Stephen Warren wrote: > From: Stephen Warren > > If snd_dmaengine_pcm_register()'s call to snd_soc_add_platform() fails, > all objects allocated during registration are leaked. Fix this by adding > error-handling code. > > Signed-off-by: Stephen Warren Yep, looks good. Thanks. This one should probably go in as a fix. Acked-by: Lars-Peter Clausen