From: Nenghua Cao <nhcao@marvell.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Henry Zhao <xzhao10@marvell.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Yacine Belkadi <yacine.belkadi.1@gmail.com>,
Chao Xie <cxie4@marvell.com>
Subject: Re: [PATCH] ASOC:DAPM: extend dapm kcontrol to support runtime route update
Date: Fri, 13 Dec 2013 19:53:21 +0800 [thread overview]
Message-ID: <52AAF531.8020200@marvell.com> (raw)
In-Reply-To: <s5hy53phthr.wl%tiwai@suse.de>
On 12/13/2013 07:37 PM, Takashi Iwai wrote:
> At Fri, 13 Dec 2013 19:33:46 +0800,
> Nenghua Cao wrote:
>> >
>> > Hi, Mark:
>> >
>> > On 12/12/2013 07:07 PM, Mark Brown wrote:
>>> > > On Thu, Dec 12, 2013 at 02:56:08AM -0800, Nenghua Cao wrote:
>>> > >
>>> > > Don't top post. Please also fix your mailer to word wrap within
>>> > > paragaphs, it makes your mails much more legible.
>>> > >
>> > It is my fault and Thanks for your kindly reminder. I just made my
>> > mailer work as community's request.
>>>>> > >> > For common mix/mux which aren't related with DPCM, it doesn't need
>>>>> > >> > to do DPCM update. And it still can use the old controls. But for
>>>>> > >> > the mix/mux which impacts fe<->be link, they need to do this works.
>>>>> > >> > For them, they call use the new set of controls. I think it can
>>>>> > >> > make our code has better backward-compatibility.
>>> > > How does this improve backwards compatibility?
>> > My thought is that we distinguish different requirement through flag
>> > (you can find dpcm_checked in my patch).
> The question is rather what do you mean as "backward compatibility".
>
> Usually backward compatibility is concerned when something new breaks
> the existing ones. In your case, always updating DPCM would work,
> too, even without an extra flag; it's just suboptimal.
>
Yes, you are right. I add this flag only for avoiding the traversing
dai_link in soc_dpcm_runtime_update(). So you think this work is
unnecessary. I will make another patch which will do DPCM runtime update
always. Is it Ok?
>
> Takashi
Thanks
next prev parent reply other threads:[~2013-12-13 11:47 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-12 8:06 [PATCH] ASOC:DAPM: extend dapm kcontrol to support runtime route update Nenghua Cao
2013-12-12 10:43 ` Mark Brown
[not found] ` <F766E4F80769BD478052FB6533FA745D4E76B8FA79@SC-VEXCH4.marvell.com>
2013-12-12 11:07 ` Mark Brown
2013-12-13 11:33 ` Nenghua Cao
2013-12-13 11:37 ` Takashi Iwai
2013-12-13 11:42 ` Mark Brown
2013-12-13 12:11 ` Nenghua Cao
2013-12-13 11:53 ` Nenghua Cao [this message]
2013-12-13 12:10 ` Mark Brown
2013-12-15 13:51 ` Vinod Koul
2013-12-12 16:52 ` Takashi Iwai
2013-12-13 11:25 ` Nenghua Cao
-- strict thread matches above, loose matches on Subject: below --
2013-12-13 11:20 [PATCH V1] " Nenghua Cao
2013-12-13 11:20 ` [PATCH] " Nenghua Cao
2013-12-13 12:10 [PATCH V2] ASOC:DAPM: update DPCM runtime when mixer/mux changes Nenghua Cao
2013-12-13 12:10 ` [PATCH] ASOC:DAPM: extend dapm kcontrol to support runtime route update Nenghua Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AAF531.8020200@marvell.com \
--to=nhcao@marvell.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cxie4@marvell.com \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
--cc=xzhao10@marvell.com \
--cc=yacine.belkadi.1@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).