alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
* [PATCH V2] ASOC:DAPM: update DPCM runtime when mixer/mux changes
@ 2013-12-13 12:13 Nenghua Cao
  2013-12-13 12:13 ` [PATCH] " Nenghua Cao
  2013-12-16 20:13 ` [PATCH V2] " Mark Brown
  0 siblings, 2 replies; 9+ messages in thread
From: Nenghua Cao @ 2013-12-13 12:13 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai, Liam Girdwood, Mark Brown,
	Yacine Belkadi, alsa-devel
  Cc: Henry zhao, Nenghua Cao, cxie4

From: Nenghua Cao <nhcao@marvell.com>

V2 -> V1:

   Removes the flag and update DPCM always when mixer/mux changes, according
to Takashi's and Mark's suggestion.

>> Usually backward compatibility is concerned when something new breaks
>> the existing ones.  In your case, always updating DPCM would work,
>> too, even without an extra flag; it's just suboptimal.

>Right, and if we have separate versions then at some point we'll end up
>having to define DPCM versions of everything which is going to get
>tedious and error prone.
 

V1 -> V0:

     refined patch, and add flag into soc_mixer_control and soc_enum 
instead of the alsa core, according to Takashi's suggestion.

> You don't need to extend the ALSA core API for such a purpose.  It's
> ASoC-specific, so rather extend struct soc_mixer_control instead, if
> such a new flag is really needed.


Nenghua Cao (1):
  ASOC:DAPM: update DPCM runtime when mixer/mux changes

 sound/soc/soc-dapm.c |   28 ++++++++++++++++++++++++----
 1 files changed, 24 insertions(+), 4 deletions(-)

^ permalink raw reply	[flat|nested] 9+ messages in thread
* Re: [PATCH]ASOC:DAPM: update DPCM runtime when mixer/mux changes
@ 2013-12-16  8:03 anish singh
  2013-12-16  9:06 ` Lars-Peter Clausen
  0 siblings, 1 reply; 9+ messages in thread
From: anish singh @ 2013-12-16  8:03 UTC (permalink / raw)
  To: alsa-devel, broonie, nhcao, lgirdwood, gabrbedd, Takashi Iwai,
	Jaroslav Kysela, Lars-Peter Clausen

<This patch is dependent on the $subject
so i have used $subject instead of different
one>
I can see only one usage of:
snd_soc_dapm_mixer_update_power
and zero user of:
snd_soc_dapm_mux_update_power()

And after this $subject patch I think
both of these functions becomes redundant.

It will help in reducing the code size if we
can get rid of this dead code.We can
also remove code from tlv320aic3x.c and
just let it use the core implementation.

grep -rniI "snd_soc_dapm_mixer_update_power" sound/

sound/soc/soc-dapm.c:2149:
int snd_soc_dapm_mixer_update_power
sound/soc/codecs/tlv320aic3x.c:174:
snd_soc_dapm_mixer_update_power

grep -rniI "snd_soc_dapm_mux_update_power" sound/
no users.

I would send a patch if experts agree.

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2013-12-17  2:53 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-13 12:13 [PATCH V2] ASOC:DAPM: update DPCM runtime when mixer/mux changes Nenghua Cao
2013-12-13 12:13 ` [PATCH] " Nenghua Cao
2013-12-15 13:56   ` Vinod Koul
2013-12-16  2:43     ` Nenghua Cao
2013-12-16 20:14   ` Mark Brown
2013-12-16 20:13 ` [PATCH V2] " Mark Brown
2013-12-17  2:59   ` Nenghua Cao
  -- strict thread matches above, loose matches on Subject: below --
2013-12-16  8:03 [PATCH]ASOC:DAPM: " anish singh
2013-12-16  9:06 ` Lars-Peter Clausen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).