From: Lars-Peter Clausen <lars@metafoo.de>
To: anish singh <anish198519851985@gmail.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
lgirdwood@gmail.com, nhcao@marvell.com, broonie@kernel.org,
gabrbedd@gmail.com
Subject: Re: [PATCH]ASOC:DAPM: update DPCM runtime when mixer/mux changes
Date: Mon, 16 Dec 2013 10:06:04 +0100 [thread overview]
Message-ID: <52AEC27C.6040105@metafoo.de> (raw)
In-Reply-To: <CAK7N6vq5RQV8JwDz7SS1K_fpXOHSmM2qOWrk8oibJZVNHcNE_A@mail.gmail.com>
On 12/16/2013 09:03 AM, anish singh wrote:
> <This patch is dependent on the $subject
> so i have used $subject instead of different
> one>
> I can see only one usage of:
> snd_soc_dapm_mixer_update_power
> and zero user of:
> snd_soc_dapm_mux_update_power()
>
> And after this $subject patch I think
> both of these functions becomes redundant.
No, the patch doesn't change anything in regard to those two functions.
Those two functions are used by drivers where the mixer or mux has a special
register layout that is not covered by the core mixer and mux update
functions and where does not make sense to add support for this to the core
functions since the layout is special.
>
> It will help in reducing the code size if we
> can get rid of this dead code.We can
> also remove code from tlv320aic3x.c and
> just let it use the core implementation.
The tlv320aic3x driver has special requirements, hence it has its own
function for updating the mux settings.
- Lars
next prev parent reply other threads:[~2013-12-16 9:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-16 8:03 [PATCH]ASOC:DAPM: update DPCM runtime when mixer/mux changes anish singh
2013-12-16 9:06 ` Lars-Peter Clausen [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-12-13 12:13 [PATCH V2] ASOC:DAPM: " Nenghua Cao
2013-12-13 12:13 ` [PATCH] " Nenghua Cao
2013-12-15 13:56 ` Vinod Koul
2013-12-16 2:43 ` Nenghua Cao
2013-12-16 20:14 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52AEC27C.6040105@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=anish198519851985@gmail.com \
--cc=broonie@kernel.org \
--cc=gabrbedd@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=nhcao@marvell.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).