From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH 1/2] ASoC: ASoC: axi-spdif: Use
 devm_ioremap_resource() instead of devm_request_and_ioremap()
Date: Mon, 16 Dec 2013 13:09:05 +0100
Message-ID: <52AEED61.6030906@metafoo.de>
References: <1387195644-28513-1-git-send-email-lars@metafoo.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <alsa-devel-bounces@alsa-project.org>
Received: from smtp-out-044.synserver.de (smtp-out-048.synserver.de
 [212.40.185.48])
 by alsa0.perex.cz (Postfix) with ESMTP id 6C82A261A06
 for <alsa-devel@alsa-project.org>; Mon, 16 Dec 2013 13:08:07 +0100 (CET)
In-Reply-To: <1387195644-28513-1-git-send-email-lars@metafoo.de>
List-Unsubscribe: <http://mailman.alsa-project.org/mailman/options/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=unsubscribe>
List-Archive: <http://mailman.alsa-project.org/pipermail/alsa-devel/>
List-Post: <mailto:alsa-devel@alsa-project.org>
List-Help: <mailto:alsa-devel-request@alsa-project.org?subject=help>
List-Subscribe: <http://mailman.alsa-project.org/mailman/listinfo/alsa-devel>,
 <mailto:alsa-devel-request@alsa-project.org?subject=subscribe>
Errors-To: alsa-devel-bounces@alsa-project.org
Sender: alsa-devel-bounces@alsa-project.org
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Fengguang Wu <fengguang.wu@intel.com>, alsa-devel@alsa-project.org, Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
List-Id: alsa-devel@alsa-project.org

oops, the subject should clearly be:

ASoC: axi-i2s: Use devm_ioremap_resource() instead \
 of devm_request_and_ioremap()

On 12/16/2013 01:07 PM, Lars-Peter Clausen wrote:
> From: Fengguang Wu <fengguang.wu@intel.com>
> 
> devm_request_and_ioremap() has been deprecated in favour of
> devm_ioremap_resource(). Fixes the following coccinelle warning:
> 
> 	sound/soc/adi/axi-i2s.c:195:8-32: ERROR: deprecated devm_request_and_ioremap() API used on line 195
> 
> Generated by: coccinelle/api/devm_ioremap_resource.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
> ---
>  sound/soc/adi/axi-i2s.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/sound/soc/adi/axi-i2s.c b/sound/soc/adi/axi-i2s.c
> index 0822c77..7f91a86 100644
> --- a/sound/soc/adi/axi-i2s.c
> +++ b/sound/soc/adi/axi-i2s.c
> @@ -192,9 +192,9 @@ static int axi_i2s_probe(struct platform_device *pdev)
>  	platform_set_drvdata(pdev, i2s);
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_request_and_ioremap(&pdev->dev, res);
> -	if (!base)
> -		return -EBUSY;
> +	base = devm_ioremap_resource(&pdev->dev, res);
> +	if (IS_ERR(base))
> +		return PTR_ERR(base);
>  
>  	i2s->regmap = devm_regmap_init_mmio(&pdev->dev, base,
>  		&axi_i2s_regmap_config);
>