alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Hui Wang <hui.wang@canonical.com>
To: David Henningsson <david.henningsson@canonical.com>
Cc: tiwai@suse.de, alsa-devel@alsa-project.org, stable@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda - Add Dell headset detection quirk for one more laptop model
Date: Tue, 17 Dec 2013 17:57:30 +0800	[thread overview]
Message-ID: <52B0200A.6050400@canonical.com> (raw)
In-Reply-To: <52B01CC2.6040208@canonical.com>

On 12/17/2013 05:43 PM, David Henningsson wrote:
> On 12/17/2013 10:39 AM, Hui Wang wrote:
>> On the Dell machines with codec whose Subsystem Id is 0x10280640,
>> no external microphone can be detected when plugging a 3-ring headset.
>> If we add "model=dell-headset-multi" for the snd-hda-intel.ko, the
>> problem will disappear.
>>
>> The codec (Vendor ID: 0x10ec0255) on the machine belongs to alc_269
>> family.
>>
>> BugLink: https://bugs.launchpad.net/bugs/1260303
>> Cc: David Henningsson <david.henningsson@canonical.com>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
>> ---
>> This patch was generated against the master branch of
>> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
>>
>>   sound/pci/hda/patch_realtek.c | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index 3578f11..4d7c602 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -4309,6 +4309,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>>   	SND_PCI_QUIRK(0x1028, 0x0638, "Dell Inspiron 5439", ALC290_FIXUP_MONO_SPEAKERS),
>>   	SND_PCI_QUIRK(0x1028, 0x063e, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
>>   	SND_PCI_QUIRK(0x1028, 0x063f, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
>> +	SND_PCI_QUIRK(0x1028, 0x0640, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
> Are you sure it shouldn't be ALC255_FIXUP_... in this line instead of
> ALC269_FIXUP_... ?
I also had the same concern as yours yesterday, so i let ShawnWang 
perform the test, he confirmed that adding "model=dell-headset-multi" 
can solve this problem. Below is the irc log:

<hwang4> shawnwang, Does adding "options snd-hda-intel 
model=,dell-headset-multi" solve the problem on this machine (10280640)
<shawnwang> hwang4, yes
<hwang4> shawnwang, ok, got it, i will fix it.

Regards,
Hui.
>>   	SND_PCI_QUIRK(0x1028, 0x15cc, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
>>   	SND_PCI_QUIRK(0x1028, 0x15cd, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
>>   	SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2),
>>
>
>

  reply	other threads:[~2013-12-17  9:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-17  9:39 [PATCH] ALSA: hda - Add Dell headset detection quirk for one more laptop model Hui Wang
2013-12-17  9:43 ` David Henningsson
2013-12-17  9:57   ` Hui Wang [this message]
2013-12-17 10:39     ` David Henningsson
2013-12-18  2:56       ` Hui Wang
2013-12-18  9:16       ` Hui Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52B0200A.6050400@canonical.com \
    --to=hui.wang@canonical.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=david.henningsson@canonical.com \
    --cc=stable@vger.kernel.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).