* [PATCH] ALSA: hda - Add Dell headset detection quirk for one more laptop model
@ 2013-12-17 9:39 Hui Wang
2013-12-17 9:43 ` David Henningsson
0 siblings, 1 reply; 6+ messages in thread
From: Hui Wang @ 2013-12-17 9:39 UTC (permalink / raw)
To: tiwai, alsa-devel; +Cc: david.henningsson, stable, hui.wang
On the Dell machines with codec whose Subsystem Id is 0x10280640,
no external microphone can be detected when plugging a 3-ring headset.
If we add "model=dell-headset-multi" for the snd-hda-intel.ko, the
problem will disappear.
The codec (Vendor ID: 0x10ec0255) on the machine belongs to alc_269
family.
BugLink: https://bugs.launchpad.net/bugs/1260303
Cc: David Henningsson <david.henningsson@canonical.com>
Cc: stable@vger.kernel.org
Signed-off-by: Hui Wang <hui.wang@canonical.com>
---
This patch was generated against the master branch of
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
sound/pci/hda/patch_realtek.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 3578f11..4d7c602 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -4309,6 +4309,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x1028, 0x0638, "Dell Inspiron 5439", ALC290_FIXUP_MONO_SPEAKERS),
SND_PCI_QUIRK(0x1028, 0x063e, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x063f, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
+ SND_PCI_QUIRK(0x1028, 0x0640, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x15cc, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x1028, 0x15cd, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2),
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: hda - Add Dell headset detection quirk for one more laptop model
2013-12-17 9:39 [PATCH] ALSA: hda - Add Dell headset detection quirk for one more laptop model Hui Wang
@ 2013-12-17 9:43 ` David Henningsson
2013-12-17 9:57 ` Hui Wang
0 siblings, 1 reply; 6+ messages in thread
From: David Henningsson @ 2013-12-17 9:43 UTC (permalink / raw)
To: Hui Wang, tiwai, alsa-devel; +Cc: stable
On 12/17/2013 10:39 AM, Hui Wang wrote:
> On the Dell machines with codec whose Subsystem Id is 0x10280640,
> no external microphone can be detected when plugging a 3-ring headset.
> If we add "model=dell-headset-multi" for the snd-hda-intel.ko, the
> problem will disappear.
>
> The codec (Vendor ID: 0x10ec0255) on the machine belongs to alc_269
> family.
>
> BugLink: https://bugs.launchpad.net/bugs/1260303
> Cc: David Henningsson <david.henningsson@canonical.com>
> Cc: stable@vger.kernel.org
> Signed-off-by: Hui Wang <hui.wang@canonical.com>
> ---
> This patch was generated against the master branch of
> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
>
> sound/pci/hda/patch_realtek.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 3578f11..4d7c602 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4309,6 +4309,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x1028, 0x0638, "Dell Inspiron 5439", ALC290_FIXUP_MONO_SPEAKERS),
> SND_PCI_QUIRK(0x1028, 0x063e, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x063f, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
> + SND_PCI_QUIRK(0x1028, 0x0640, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
Are you sure it shouldn't be ALC255_FIXUP_... in this line instead of
ALC269_FIXUP_... ?
> SND_PCI_QUIRK(0x1028, 0x15cc, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x1028, 0x15cd, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
> SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2),
>
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: hda - Add Dell headset detection quirk for one more laptop model
2013-12-17 9:43 ` David Henningsson
@ 2013-12-17 9:57 ` Hui Wang
2013-12-17 10:39 ` David Henningsson
0 siblings, 1 reply; 6+ messages in thread
From: Hui Wang @ 2013-12-17 9:57 UTC (permalink / raw)
To: David Henningsson; +Cc: tiwai, alsa-devel, stable
On 12/17/2013 05:43 PM, David Henningsson wrote:
> On 12/17/2013 10:39 AM, Hui Wang wrote:
>> On the Dell machines with codec whose Subsystem Id is 0x10280640,
>> no external microphone can be detected when plugging a 3-ring headset.
>> If we add "model=dell-headset-multi" for the snd-hda-intel.ko, the
>> problem will disappear.
>>
>> The codec (Vendor ID: 0x10ec0255) on the machine belongs to alc_269
>> family.
>>
>> BugLink: https://bugs.launchpad.net/bugs/1260303
>> Cc: David Henningsson <david.henningsson@canonical.com>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
>> ---
>> This patch was generated against the master branch of
>> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
>>
>> sound/pci/hda/patch_realtek.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
>> index 3578f11..4d7c602 100644
>> --- a/sound/pci/hda/patch_realtek.c
>> +++ b/sound/pci/hda/patch_realtek.c
>> @@ -4309,6 +4309,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>> SND_PCI_QUIRK(0x1028, 0x0638, "Dell Inspiron 5439", ALC290_FIXUP_MONO_SPEAKERS),
>> SND_PCI_QUIRK(0x1028, 0x063e, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
>> SND_PCI_QUIRK(0x1028, 0x063f, "Dell", ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
>> + SND_PCI_QUIRK(0x1028, 0x0640, "Dell", ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
> Are you sure it shouldn't be ALC255_FIXUP_... in this line instead of
> ALC269_FIXUP_... ?
I also had the same concern as yours yesterday, so i let ShawnWang
perform the test, he confirmed that adding "model=dell-headset-multi"
can solve this problem. Below is the irc log:
<hwang4> shawnwang, Does adding "options snd-hda-intel
model=,dell-headset-multi" solve the problem on this machine (10280640)
<shawnwang> hwang4, yes
<hwang4> shawnwang, ok, got it, i will fix it.
Regards,
Hui.
>> SND_PCI_QUIRK(0x1028, 0x15cc, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
>> SND_PCI_QUIRK(0x1028, 0x15cd, "Dell X5 Precision", ALC269_FIXUP_DELL2_MIC_NO_PRESENCE),
>> SND_PCI_QUIRK(0x103c, 0x1586, "HP", ALC269_FIXUP_HP_MUTE_LED_MIC2),
>>
>
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: hda - Add Dell headset detection quirk for one more laptop model
2013-12-17 9:57 ` Hui Wang
@ 2013-12-17 10:39 ` David Henningsson
2013-12-18 2:56 ` Hui Wang
2013-12-18 9:16 ` Hui Wang
0 siblings, 2 replies; 6+ messages in thread
From: David Henningsson @ 2013-12-17 10:39 UTC (permalink / raw)
To: Hui Wang; +Cc: tiwai, alsa-devel, stable
On 12/17/2013 10:57 AM, Hui Wang wrote:
> On 12/17/2013 05:43 PM, David Henningsson wrote:
>> On 12/17/2013 10:39 AM, Hui Wang wrote:
>>> On the Dell machines with codec whose Subsystem Id is 0x10280640,
>>> no external microphone can be detected when plugging a 3-ring headset.
>>> If we add "model=dell-headset-multi" for the snd-hda-intel.ko, the
>>> problem will disappear.
>>>
>>> The codec (Vendor ID: 0x10ec0255) on the machine belongs to alc_269
>>> family.
>>>
>>> BugLink: https://bugs.launchpad.net/bugs/1260303
>>> Cc: David Henningsson <david.henningsson@canonical.com>
>>> Cc: stable@vger.kernel.org
>>> Signed-off-by: Hui Wang <hui.wang@canonical.com>
>>> ---
>>> This patch was generated against the master branch of
>>> git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
>>>
>>> sound/pci/hda/patch_realtek.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/sound/pci/hda/patch_realtek.c
>>> b/sound/pci/hda/patch_realtek.c
>>> index 3578f11..4d7c602 100644
>>> --- a/sound/pci/hda/patch_realtek.c
>>> +++ b/sound/pci/hda/patch_realtek.c
>>> @@ -4309,6 +4309,7 @@ static const struct snd_pci_quirk
>>> alc269_fixup_tbl[] = {
>>> SND_PCI_QUIRK(0x1028, 0x0638, "Dell Inspiron 5439",
>>> ALC290_FIXUP_MONO_SPEAKERS),
>>> SND_PCI_QUIRK(0x1028, 0x063e, "Dell",
>>> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
>>> SND_PCI_QUIRK(0x1028, 0x063f, "Dell",
>>> ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
>>> + SND_PCI_QUIRK(0x1028, 0x0640, "Dell",
>>> ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
>> Are you sure it shouldn't be ALC255_FIXUP_... in this line instead of
>> ALC269_FIXUP_... ?
> I also had the same concern as yours yesterday, so i let ShawnWang
> perform the test, he confirmed that adding "model=dell-headset-multi"
> can solve this problem. Below is the irc log:
>
> <hwang4> shawnwang, Does adding "options snd-hda-intel
> model=,dell-headset-multi" solve the problem on this machine (10280640)
> <shawnwang> hwang4, yes
> <hwang4> shawnwang, ok, got it, i will fix it.
Well, just because the alc269 model works does not mean that the alc255
model does not work. They are quite similar, with the only difference
being a few verbs set on initial boot. Maybe those verbs handle some
corner case that was not tested explicitly by Shawn.
--
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: hda - Add Dell headset detection quirk for one more laptop model
2013-12-17 10:39 ` David Henningsson
@ 2013-12-18 2:56 ` Hui Wang
2013-12-18 9:16 ` Hui Wang
1 sibling, 0 replies; 6+ messages in thread
From: Hui Wang @ 2013-12-18 2:56 UTC (permalink / raw)
To: David Henningsson; +Cc: tiwai, alsa-devel, stable
On 12/17/2013 06:39 PM, David Henningsson wrote:
>>>> SND_PCI_QUIRK(0x1028, 0x0638, "Dell Inspiron 5439",
>>>> >>>ALC290_FIXUP_MONO_SPEAKERS),
>>>> >>> SND_PCI_QUIRK(0x1028, 0x063e, "Dell",
>>>> >>>ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
>>>> >>> SND_PCI_QUIRK(0x1028, 0x063f, "Dell",
>>>> >>>ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
>>>> >>>+ SND_PCI_QUIRK(0x1028, 0x0640, "Dell",
>>>> >>>ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
>>> >>Are you sure it shouldn't be ALC255_FIXUP_... in this line instead of
>>> >>ALC269_FIXUP_... ?
>> >I also had the same concern as yours yesterday, so i let ShawnWang
>> >perform the test, he confirmed that adding "model=dell-headset-multi"
>> >can solve this problem. Below is the irc log:
>> >
>> ><hwang4> shawnwang, Does adding "options snd-hda-intel
>> >model=,dell-headset-multi" solve the problem on this machine (10280640)
>> ><shawnwang> hwang4, yes
>> ><hwang4> shawnwang, ok, got it, i will fix it.
> Well, just because the alc269 model works does not mean that the alc255
> model does not work. They are quite similar, with the only difference
> being a few verbs set on initial boot. Maybe those verbs handle some
> corner case that was not tested explicitly by Shawn.
All right, I am going to let Shawn redo the test.
Regards,
Hui.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ALSA: hda - Add Dell headset detection quirk for one more laptop model
2013-12-17 10:39 ` David Henningsson
2013-12-18 2:56 ` Hui Wang
@ 2013-12-18 9:16 ` Hui Wang
1 sibling, 0 replies; 6+ messages in thread
From: Hui Wang @ 2013-12-18 9:16 UTC (permalink / raw)
To: David Henningsson; +Cc: tiwai, alsa-devel, stable
On 12/17/2013 06:39 PM, David Henningsson wrote:
>>>> --- a/sound/pci/hda/patch_realtek.c
>>>> >>>+++ b/sound/pci/hda/patch_realtek.c
>>>> >>>@@ -4309,6 +4309,7 @@ static const struct snd_pci_quirk
>>>> >>>alc269_fixup_tbl[] = {
>>>> >>> SND_PCI_QUIRK(0x1028, 0x0638, "Dell Inspiron 5439",
>>>> >>>ALC290_FIXUP_MONO_SPEAKERS),
>>>> >>> SND_PCI_QUIRK(0x1028, 0x063e, "Dell",
>>>> >>>ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
>>>> >>> SND_PCI_QUIRK(0x1028, 0x063f, "Dell",
>>>> >>>ALC255_FIXUP_DELL1_MIC_NO_PRESENCE),
>>>> >>>+ SND_PCI_QUIRK(0x1028, 0x0640, "Dell",
>>>> >>>ALC269_FIXUP_DELL1_MIC_NO_PRESENCE),
>>> >>Are you sure it shouldn't be ALC255_FIXUP_... in this line instead of
>>> >>ALC269_FIXUP_... ?
>> >I also had the same concern as yours yesterday, so i let ShawnWang
>> >perform the test, he confirmed that adding "model=dell-headset-multi"
>> >can solve this problem. Below is the irc log:
>> >
>> ><hwang4> shawnwang, Does adding "options snd-hda-intel
>> >model=,dell-headset-multi" solve the problem on this machine (10280640)
>> ><shawnwang> hwang4, yes
>> ><hwang4> shawnwang, ok, got it, i will fix it.
> Well, just because the alc269 model works does not mean that the alc255
> model does not work. They are quite similar, with the only difference
> being a few verbs set on initial boot. Maybe those verbs handle some
> corner case that was not tested explicitly by Shawn.
Shawn has done the test, according to his test result, both ALC255_FIXUP
and ALC269_FIXUP can fix headset detection bug, and furthermore he also
did the record and playback test for them, the result was same, no
matter we choose ALC255 or ALC269, the machine can correctly detect,
record and playback.
Since the codec's vendor ID is 0x10ec0255, choosing ALC255_FIXUP is more
reasonable and safer.
Regards,
Hui.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-12-18 9:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-12-17 9:39 [PATCH] ALSA: hda - Add Dell headset detection quirk for one more laptop model Hui Wang
2013-12-17 9:43 ` David Henningsson
2013-12-17 9:57 ` Hui Wang
2013-12-17 10:39 ` David Henningsson
2013-12-18 2:56 ` Hui Wang
2013-12-18 9:16 ` Hui Wang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).