From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"haojian.zhuang@gmail.com" <haojian.zhuang@gmail.com>,
Qiao Zhou <zhouqiao@marvell.com>,
"zhangfei.gao@gmail.com" <zhangfei.gao@gmail.com>
Subject: Re: [PATCH] ASoC: mmp-pcm: config pcm slave via generic dmaengine
Date: Wed, 18 Dec 2013 11:14:36 +0100 [thread overview]
Message-ID: <52B1758C.1020903@metafoo.de> (raw)
In-Reply-To: <20131218110318.GC28455@sirena.org.uk>
On 12/18/2013 12:03 PM, Mark Brown wrote:
> On Wed, Dec 18, 2013 at 10:16:36AM +0100, Lars-Peter Clausen wrote:
>
>> +#ifdef CONFIG_CPU_MMP2
>> + /*
>> + * Temporary hack until we have a generic gen_pool lookup
>> + * infrastructure.
>> + */
>> + if (!pool)
>> + pool = sram_get_gpool("asram");
>> +#endif
>
> I worry about what this'd do on a multiplatform kernel - it seems
> unlikely that someone has a pool with the same name but that sounds like
> famous last words. Nothing in mainline does though so...
The sram_get_gpool() function is mmp2 specific. It basically iterates a list
of available pools. Those pools are registered by mmp2 platform code. So on
a multiplatform kernel not booting mmp2 it will always return NULL since no
pools have been registered.
- Lars
next prev parent reply other threads:[~2013-12-18 11:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-17 8:22 [PATCH] ASoC: mmp-pcm: config pcm slave via generic dmaengine Qiao Zhou
2013-12-17 12:49 ` Mark Brown
2013-12-17 14:42 ` Lars-Peter Clausen
2013-12-17 21:38 ` Mark Brown
2013-12-18 5:55 ` Qiao Zhou
2013-12-18 9:16 ` Lars-Peter Clausen
2013-12-18 10:20 ` Takashi Iwai
2013-12-18 11:03 ` Mark Brown
2013-12-18 10:14 ` Lars-Peter Clausen [this message]
2013-12-18 11:20 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52B1758C.1020903@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=haojian.zhuang@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=tiwai@suse.de \
--cc=zhangfei.gao@gmail.com \
--cc=zhouqiao@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).