From: Lars-Peter Clausen <lars@metafoo.de>
To: Leon Romanovsky <leon@leon.nu>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
linaro-kernel@lists.linaro.org, Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH 2/8] ASoC: alc5632: Use params_width() rather than memory format
Date: Thu, 09 Jan 2014 11:16:48 +0100 [thread overview]
Message-ID: <52CE7710.7080207@metafoo.de> (raw)
In-Reply-To: <CALq1K=Kss-NUYB-mmhOjCbxSjhaRO62GpnY95rFMzruo35i=fw@mail.gmail.com>
On 01/09/2014 05:55 AM, Leon Romanovsky wrote:
> Hi Mark,
>
> On Wed, Jan 8, 2014 at 9:51 PM, Mark Brown <broonie@kernel.org> wrote:
>> From: Mark Brown <broonie@linaro.org>
>>
>> Signed-off-by: Mark Brown <broonie@linaro.org>
>> ---
>> sound/soc/codecs/alc5632.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/sound/soc/codecs/alc5632.c b/sound/soc/codecs/alc5632.c
>> index 19e9f222d09c..fb001c56cf8d 100644
>> --- a/sound/soc/codecs/alc5632.c
>> +++ b/sound/soc/codecs/alc5632.c
>> @@ -869,14 +869,14 @@ static int alc5632_pcm_hw_params(struct snd_pcm_substream *substream,
>> iface &= ~ALC5632_DAI_I2S_DL_MASK;
>>
>> /* bit size */
>> - switch (params_format(params)) {
>> - case SNDRV_PCM_FORMAT_S16_LE:
>> + switch (params_width(params)) {
>> + case 16:
> May be the better way will be to use define here and not hard coded value?
like #define SIXTEEN 16? ;)
next prev parent reply other threads:[~2014-01-09 10:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-08 19:51 [PATCH 1/8] ASoC: alc5623: Use params_width() rather than memory format Mark Brown
2014-01-08 19:51 ` [PATCH 2/8] ASoC: alc5632: " Mark Brown
2014-01-09 4:55 ` Leon Romanovsky
2014-01-09 10:16 ` Lars-Peter Clausen [this message]
2014-01-09 10:33 ` Mark Brown
2014-01-10 13:44 ` Leon Romanovsky
2014-01-10 13:51 ` Takashi Iwai
2014-01-08 19:51 ` [PATCH 3/8] ASoC: cs42l51: " Mark Brown
2014-01-08 19:51 ` [PATCH 4/8] ASoC: da7210: " Mark Brown
2014-01-08 19:52 ` [PATCH 5/8] ASoC: da7213: " Mark Brown
2014-01-08 19:52 ` [PATCH 6/8] ASoC: da732x: " Mark Brown
2014-01-08 19:52 ` [PATCH 7/8] ASoC: da9055: " Mark Brown
2014-01-08 19:52 ` [PATCH 8/8] ASoC: isabelle: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52CE7710.7080207@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=leon@leon.nu \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox