From: Clemens Ladisch <clemens@ladisch.de>
To: Mark Brown <broonie@kernel.org>, Roman Volkov <v1ron@mail.ru>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH v4 07/19] ALSA: Oxygen: Add new CS4245 SPI functions
Date: Fri, 24 Jan 2014 15:46:46 +0100 [thread overview]
Message-ID: <52E27CD6.7010109@ladisch.de> (raw)
In-Reply-To: <20140124134351.GC11727@sirena.org.uk>
Mark Brown wrote:
> On Fri, Jan 24, 2014 at 04:18:08PM +0400, Roman Volkov wrote:
>> Add the new SPI write and read functions. The SPI read function
>> is used for creating initial registers dump and may be used for
>> debugging purposes. SPI operations are cached, so there is a new
>> function to manage the cache (shadow). I have to remove
>> the shift from the CS4245_SPI_* constants, since when
>> we are performing the reading, we need to shift by 8 instead
>> of 16.
>
> I can't help but think that this driver ought to be making more use of
> frameworks
Everbody else thinks the same: <http://lkml.org/lkml/2012/3/13/215>.
Unfortunately, thinking requires less effort than writing patches.
Regards,
Clemens
next prev parent reply other threads:[~2014-01-24 14:46 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-24 12:18 [PATCH v4 01/19] ALSA: Oxygen: Add the separate SPI waiting function Roman Volkov
2014-01-24 12:18 ` [PATCH v4 02/19] ALSA: Oxygen: Modify the SPI writing function Roman Volkov
2014-01-24 12:18 ` [PATCH v4 03/19] ALSA: Oxygen: Add mute mask for the OXYGEN_PLAY_ROUTING register Roman Volkov
2014-01-24 12:18 ` [PATCH v4 04/19] ALSA: Oxygen: Export oxygen_update_dac_routing symbol Roman Volkov
2014-01-24 12:18 ` [PATCH v4 05/19] ALSA: Oxygen: Change description of the xonar_dg.c file Roman Volkov
2014-01-24 12:18 ` [PATCH v4 06/19] ALSA: Oxygen: Additional definitions for the Xonar DG/DGX card Roman Volkov
2014-01-24 12:18 ` [PATCH v4 07/19] ALSA: Oxygen: Add new CS4245 SPI functions Roman Volkov
2014-01-24 13:43 ` Mark Brown
2014-01-24 14:46 ` Clemens Ladisch [this message]
2014-01-24 12:18 ` [PATCH v4 08/19] ALSA: Oxygen: Modify initialization functions Roman Volkov
2014-01-24 12:18 ` [PATCH v4 09/19] ALSA: Oxygen: Modify DAC/ADC parameters function Roman Volkov
2014-01-24 12:18 ` [PATCH v4 10/19] ALSA: Oxygen: Modify adjust_dg_dac_routing function Roman Volkov
2014-01-24 12:18 ` [PATCH v4 11/19] ALSA: Oxygen: Modify CS4245 register dumping function Roman Volkov
2014-01-24 12:18 ` [PATCH v4 12/19] ALSA: Oxygen: Move the mixer code into another file Roman Volkov
2014-01-24 12:18 ` [PATCH v4 13/19] ALSA: Oxygen: Capture from I2S channel 1, not 2 Roman Volkov
2014-01-24 12:18 ` [PATCH v4 14/19] ALSA: Oxygen: Modify playback output select Roman Volkov
2014-01-24 12:18 ` [PATCH v4 15/19] ALSA: Oxygen: Use headphone volume control Roman Volkov
2014-01-24 12:18 ` [PATCH v4 16/19] ALSA: Oxygen: Modify capture volume functions Roman Volkov
2014-01-24 12:18 ` [PATCH v4 17/19] ALSA: Oxygen: Modify input select functions Roman Volkov
2014-01-24 12:18 ` [PATCH v4 18/19] ALSA: Oxygen: Modify High-pass filter control Roman Volkov
2014-01-24 12:18 ` [PATCH v4 19/19] ALSA: Oxygen: Cleanup and minor changes Roman Volkov
2014-01-29 21:06 ` [GIT PULL] real support for Xonar DG(X), for 3.15 Clemens Ladisch
2014-01-30 11:43 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52E27CD6.7010109@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=v1ron@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox