From: Markus Elfring <Markus.Elfring@web.de>
To: Defang Bo <bodefang@126.com>, alsa-devel@alsa-project.org
Cc: kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
linux-kernel@vger.kernel.org,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Tom Yan <tom.ty89@gmail.com>
Subject: Re: [PATCH] ALSA: usb-audio: check urb before kill it
Date: Mon, 28 Dec 2020 12:28:18 +0100 [thread overview]
Message-ID: <52c7a12d-3eeb-b8cd-c1a3-05a1c70a7f9f@web.de> (raw)
In-Reply-To: <1609074299-3990670-1-git-send-email-bodefang@126.com>
> Similar to commit<124751d5e>, there should be a check for urb before kill it.
I suggest to reconsider this change description.
How does it fit to the information “may be NULL” from the function documentation?
https://elixir.bootlin.com/linux/v5.10.3/source/drivers/usb/core/urb.c#L677
Regards,
Markus
next prev parent reply other threads:[~2020-12-28 11:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-27 13:04 [PATCH] ALSA:usb-audio:check urb before kill it Defang Bo
2020-12-28 11:28 ` Markus Elfring [this message]
2020-12-29 8:25 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=52c7a12d-3eeb-b8cd-c1a3-05a1c70a7f9f@web.de \
--to=markus.elfring@web.de \
--cc=alsa-devel@alsa-project.org \
--cc=bodefang@126.com \
--cc=kai.heng.feng@canonical.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
--cc=tom.ty89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox