Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Das, Nirmoy" <nirmoy.das@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, lucas.demarchi@intel.com,
	tiwai@suse.com, kai.vehmanen@linux.intel.com,
	matthew.auld@intel.com
Subject: Re: [PATCH v2] ALSA: hda: handle UAF at probe error
Date: Fri, 15 Apr 2022 10:16:56 +0200	[thread overview]
Message-ID: <52cf7f2f-ea63-8095-6147-750af9a5f2dc@intel.com> (raw)
In-Reply-To: <s5h5yna4xil.wl-tiwai@suse.de>


On 4/15/2022 9:27 AM, Takashi Iwai wrote:
> On Thu, 14 Apr 2022 20:24:37 +0200,
> Nirmoy Das wrote:
>> Call snd_card_free_on_error() on probe error instead of
>> calling snd_card_free() which should handle devres call orders.
> This won't change any practical behavior, because HD-audio driver
> doesn't use snd_devm_card_new().

OK, I guess I am looking into some timing dependent issue because with the

patch I didn't see the UAF.


Thanks,

Nirmoy


>   snd_card_free() still gets called
> explicitly in the relevant code paths.
>
>> Issues: https://gitlab.freedesktop.org/drm/intel/-/issues/5701
> So it must be a different cause for this problem...
>
>
> thanks,
>
> Takashi

      reply	other threads:[~2022-04-19 11:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20220414182437.14944-1-nirmoy.das@intel.com>
2022-04-15  4:23 ` [PATCH v2] ALSA: hda: handle UAF at probe error Lucas De Marchi
2022-04-15  8:24   ` Das, Nirmoy
2022-04-15  7:27 ` Takashi Iwai
2022-04-15  8:16   ` Das, Nirmoy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=52cf7f2f-ea63-8095-6147-750af9a5f2dc@intel.com \
    --to=nirmoy.das@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=lucas.demarchi@intel.com \
    --cc=matthew.auld@intel.com \
    --cc=tiwai@suse.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox