From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [alsa-devel] [PATCH 01/10] ASoC: core: Add snd_soc_dai_set_tdm_slot_xlate(). Date: Sat, 01 Mar 2014 14:19:44 +0100 Message-ID: <5311DE70.7000901@metafoo.de> References: <1393387175-15539-1-git-send-email-Li.Xiubo@freescale.com> <1393387175-15539-2-git-send-email-Li.Xiubo@freescale.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1393387175-15539-2-git-send-email-Li.Xiubo@freescale.com> Sender: linux-kernel-owner@vger.kernel.org To: Xiubo Li Cc: broonie@kernel.org, lgirdwood@gmail.com, fabio.estevam@freescale.com, moinejf@free.fr, alsa-devel@alsa-project.org, kuninori.morimoto.gx@renesas.com, tiwai@suse.de, s.hauer@pengutronix.de, timur@tabi.org, linux-kernel@vger.kernel.org, denis@eukrea.com, Guangyu.Chen@freescale.com, mpa@pengutronix.de, shawn.guo@linaro.org List-Id: alsa-devel@alsa-project.org On 02/26/2014 04:59 AM, Xiubo Li wrote: > For most cases the rx_mask and tx_mask params have no use for > snd_soc_dai_set_tdm_slot(), because they could be generated by > {XXX_ .}of_xlate_tdm_slot_mask(). > > This patch add snd_soc_dai_set_tdm_slot_xlate() which will replace > the snd_soc_dai_set_tdm_slot() in some use cases to simplify the > code. And for some CODECs or CPU DAI devices there needed much more > work to support the .of_xlate_tdm_slot_mask feature. > > This patch can be applied to most use case of the current DAI drivers. Hi, I'm not quite sure I fully understand what this patch is trying to solve. It adds a variant snd_soc_dai_set_tdm_slot() that instead of taking a rx and tx mask calculates the masks based on the number of slots? In that case I don't really see how the xlate in the name relates to that. xlate is something you'd typically expect in a devicetree context. Maybe one should be called snd_soc_dai_set_tdm_slot() and the other snd_soc_dai_set_tdm_slot_and_masks()? But another question is do we really need this? I don't see the problem that is solved by this patchset. - Lars