From: Jarkko Nikula <jarkko.nikula@bitmer.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Peter Ujfalusi <peter.ujfalusi@ti.com>,
linux-omap@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH] sound: omap: n810: fix init with DT boot
Date: Mon, 03 Mar 2014 20:41:07 +0200 [thread overview]
Message-ID: <5314CCC3.3020604@bitmer.com> (raw)
In-Reply-To: <1393697317-16733-1-git-send-email-aaro.koskinen@iki.fi>
On 03/01/2014 08:08 PM, Aaro Koskinen wrote:
> Since 3.14-rc1 only DT boot has been supported on N810. Make a minimal
> fix to retain functionality. This file should be properly converted
> to DT in longer term.
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@iki.fi>
> ---
> sound/soc/omap/n810.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Right, so there is actually regression. Can you get codec to probe? I
get this when drivers are modules:
tlv320aic3x-codec: probe of 1-0018 failed with error -16
I don't see quickly from where this -EBUSY comes but
arch/arm/mach-omap2/board-n8x0.c seems to register it since module is
loaded.
With your patch basic n810 machine driver probing works again although
audio card is not registered for me due failing codec probe.
Please resend you fix and cc maintainers Mark Brown <broonie@kernel.org>
and Liam Girdwood <lgirdwood@gmail.com>. You can add my ack
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
prev parent reply other threads:[~2014-03-03 18:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-01 18:08 [PATCH] sound: omap: n810: fix init with DT boot Aaro Koskinen
2014-03-03 18:41 ` Jarkko Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5314CCC3.3020604@bitmer.com \
--to=jarkko.nikula@bitmer.com \
--cc=aaro.koskinen@iki.fi \
--cc=alsa-devel@alsa-project.org \
--cc=linux-omap@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox