Re: [PATCH] ASoC: dapm: Add support for multi register mux

Lars-Peter Clausen
2014-04-04T07:31:32Z

On 04/03/2014 10:11 PM, Arun Shamanna Lakshmi wrote:
[...]
>> Here as well, default for bit_pos should be 0.
>
> This means when 'None' of the options are selected, by default, it
> enumerates to 0. Since we are using __ffs, BIT(0) of Register-0 also
> enumerates to 0. That's the reason why I used just ffs in the first place.
> Let me know your opinion. My value table looks like below.
>
> #define MUX_VALUE(npart, nbit) (nbit + 32 * npart)
> static const int mux_values[] = {
> 0,
> MUX_VALUE(0, 0),
> .
> .
> .
> MUX_VALUE(0, 31),
> /* above inputs are for part0 mux */
> MUX_VALUE(1, 0),
> .
> .
> .
> MUX_VALUE(1, 31),
> /* above inputs are for part1 mux */
> MUX_VALUE(2, 0),
> .
> .
> .
> MUX_VALUE(2, 31),
> /* above inputs are for part2 mux */
> };

Ok, so having none of the input selected should be a valid user selectable
option?