From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44663C433FE for ; Fri, 30 Sep 2022 08:40:38 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 6C9BE166C; Fri, 30 Sep 2022 10:39:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 6C9BE166C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1664527236; bh=E+BdStv7jSermFK3Q5InwQ6aKkfEO1DTevs1KsaSxag=; h=Date:Subject:To:References:From:In-Reply-To:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=STZOwyJS9DAd8xnu8SCCv8sofo0zwMQcXS0iKhWGikGU08Tbc9AkccjwQMP5fPUFU CKU2afKCl5q0eUs0NFzFxZwMUzWwFZjGpz0OcKehIu1xiWhC07FWGwl2GiVth1+fDi UCcFKGwaXlJkRWXovDV+NwxgDjYD1CzZIn/F8dkc= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 0148AF80153; Fri, 30 Sep 2022 10:39:46 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3C0E1F80155; Fri, 30 Sep 2022 10:39:44 +0200 (CEST) Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 59660F800E8 for ; Fri, 30 Sep 2022 10:39:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 59660F800E8 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=collabora.com header.i=@collabora.com header.b="lNeI6R1E" Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 9A03266022C7; Fri, 30 Sep 2022 09:39:36 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1664527177; bh=E+BdStv7jSermFK3Q5InwQ6aKkfEO1DTevs1KsaSxag=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=lNeI6R1EXXnZ45AMl3XkvLawGjH/VJQOtxkkFpLQe4SCdssJu3/m5B0GDOXVotcMZ hKcUjbhdQomv+eInmQyK+AFRV8dB5wc3VbNcjc4w4/JucBt45ERANOwpdpViZMjXax sTw8H1sjGzeOhxk4SZB4YY/oUBJyo4XGl+TcbvXSvbWzgClyokOs6URnn3elSYStCT L6iG9TbuhlpgoVpxXi9bDUTlg7lIbnx4OnlyVdrJRpBj1nk9FmiYHpyuWM048d7a3K ZM4wIzR9+a1Ek9/kFJVcJ4j/F2IDU29GOAwq57ojVymvNo1xZnR/V0xVudHLnyHSm5 +02hVKys4vdmg== Message-ID: <533c4451-a172-df81-c34a-a3ec906a961e@collabora.com> Date: Fri, 30 Sep 2022 10:39:34 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v2 -next 4/4] ASoC: mt6660: Fix PM disable depth imbalance in mt6660_i2c_probe Content-Language: en-US To: Zhang Qilong , lgirdwood@gmail.com, broonie@kernel.org, perex@perex.cz, tiwai@suse.com, matthias.bgg@gmail.com, ckeepax@opensource.wolfsonmicro.com, jeff_chang@richtek.com References: <20220929150653.63845-1-zhangqilong3@huawei.com> <20220929150653.63845-5-zhangqilong3@huawei.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220929150653.63845-5-zhangqilong3@huawei.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: patches@opensource.cirrus.com, alsa-devel@alsa-project.org, linux-mediatek@lists.infradead.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" Il 29/09/22 17:06, Zhang Qilong ha scritto: > The pm_runtime_enable will increase power disable depth. Thus > a pairing decrement is needed on the error handling path to > keep it balanced according to context. We fix it by calling > pm_runtime_disable when error returns. > > Fixes:f289e55c6eeb4 ("ASoC: Add MediaTek MT6660 Speaker Amp Driver") > Signed-off-by: Zhang Qilong Reviewed-by: AngeloGioacchino Del Regno