From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, Jyri Sarha <jsarha@ti.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
notasas@gmail.com
Subject: Re: [PATCH 02/18] ASoC: omap-mcpdm: Assign the dai DMA data at earlier time
Date: Wed, 16 Apr 2014 13:25:31 +0300 [thread overview]
Message-ID: <534E5A9B.4050900@ti.com> (raw)
In-Reply-To: <20140416101535.GQ12304@sirena.org.uk>
On 04/16/2014 01:15 PM, Mark Brown wrote:
> On Wed, Apr 16, 2014 at 12:23:15PM +0300, Peter Ujfalusi wrote:
>
>> - snd_soc_dai_set_dma_data(dai, substream,
>> - &mcpdm->dma_data[substream->stream]);
>> -
>> return 0;
>> }
>>
>> @@ -406,6 +403,10 @@ static int omap_mcpdm_probe(struct snd_soc_dai *dai)
>> mcpdm->config[SNDRV_PCM_STREAM_PLAYBACK].threshold = 2;
>> mcpdm->config[SNDRV_PCM_STREAM_CAPTURE].threshold =
>> MCPDM_UP_THRES_MAX - 3;
>> +
>> + dai->playback_dma_data = &mcpdm->dma_data[SNDRV_PCM_STREAM_PLAYBACK];
>> + dai->capture_dma_data = &mcpdm->dma_data[SNDRV_PCM_STREAM_CAPTURE];
>> +
>
> Any reason to stop using _set_dma_data()?
At dai driver probe we do not have substream and snd_soc_dai_set_dma_data()
relies on that (substream->stream) to figure out which dma_data to set.
This change is not a must for omap right now, but I have seen on davinci that
we need to have the playback/capture_dma_data set at this time if we are using
the ASoC generic dmaengine pcm for platform (I use edma-pcm on davinci right now).
--
Péter
next prev parent reply other threads:[~2014-04-16 10:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 9:23 [PATCH 00/18] ASoC: omap: Bind the omap-pcm platform driver to dai device Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 01/18] ASoC: omap-pcm: Support for binding the platform driver to dai devices Peter Ujfalusi
2014-04-16 9:30 ` Peter Ujfalusi
2014-04-16 11:01 ` Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 02/18] ASoC: omap-mcpdm: Assign the dai DMA data at earlier time Peter Ujfalusi
2014-04-16 10:15 ` Mark Brown
2014-04-16 10:25 ` Peter Ujfalusi [this message]
2014-04-16 12:23 ` Lars-Peter Clausen
2014-04-16 9:23 ` [PATCH 03/18] ASoC: omap-mcpdm: Bind the platform driver to the dai driver when loading Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 04/18] ASoC: omap-mcbsp: Assign the dai DMA data at earlier time Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 05/18] ASoC: omap-mcbsp: Bind the platform driver to the dai driver when loading Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 06/18] ASoC: omap-dmic: Assign the dai DMA data at earlier time Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 07/18] ASoC: omap-dmic: Bind the platform driver to the dai driver when loading Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 08/18] ASoC: omap-hdmi: " Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 09/18] ASoC: omap-abe-twl6040: Use the cpu_dai node to specify the platform driver Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 10/18] ASoC: omap-twl4030: Use the same name/node for platform as the cpu_dai Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 11/18] ASoC: am3517evm: Use the same name " Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 12/18] ASoC: ams-delta: " Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 13/18] ASoC: n810: " Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 14/18] ASoC: omap3pandora: " Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 15/18] ASoC: osk5912: " Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 16/18] ASoC: rx51: " Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 17/18] ASoC: omap-hdmi-card: " Peter Ujfalusi
2014-04-16 9:23 ` [PATCH 18/18] ASoC: omap-pcm: Drop the platform driver init code Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=534E5A9B.4050900@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jarkko.nikula@bitmer.com \
--cc=jsarha@ti.com \
--cc=lgirdwood@gmail.com \
--cc=notasas@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox