From mboxrd@z Thu Jan 1 00:00:00 1970 From: Clemens Ladisch Subject: Re: [PATCH v2] Fix forward/rewind support in iec958 plugin Date: Fri, 25 Apr 2014 10:09:37 +0200 Message-ID: <535A1841.8070208@ladisch.de> References: <5358F356.3020701@canonical.com> <1398350406-10347-1-git-send-email-patrakov@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from dehamd003.servertools24.de (dehamd003.servertools24.de [31.47.254.18]) by alsa0.perex.cz (Postfix) with ESMTP id 48A9226535B for ; Fri, 25 Apr 2014 10:09:38 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Raymond Yau , "Alexander E. Patrakov" Cc: tiwai@suse.de, alsa-devel@alsa-project.org List-Id: alsa-devel@alsa-project.org Raymond Yau wrote: >> When forwarding or rewinding, the frame counter was not updated. This >> could result in corrupted channel status words or misplaced Z-type >> preamble. > > Do you mean it is the responsibility for a52 and dca plugin to return the > SAFE value returned by snd_pcm_rewindable and snd_pcm_forwardable since > they enocde the audio and padding zeros and write to IEC958 ? The a52/dca plugins create data to be transferred over S/PDIF, but this does not imply they use the iec958 plugin. The iec958 plugin is used for sound cards that do not have a hardware IEC958 encoder. This is very unlikely nowadays. Regards, Clemens