From: Clemens Ladisch <clemens@ladisch.de>
To: ralfbeck1@gmx.de, alsa-devel@alsa-project.org
Subject: Re: [PATCH]: snd_seq_virmidi.c do not use running status for virmidi raw input
Date: Wed, 07 May 2014 22:41:20 +0200 [thread overview]
Message-ID: <536A9A70.4020401@ladisch.de> (raw)
In-Reply-To: <536A7104.7010009@gmx.de>
Ralf Beck wrote:
> Rationale: Not every rawmidi alsa client (e.q. Bitwig) support running status on input.
Why does Bitwig use RawMIDI when it is only interested in the events?
Anyway, running status is part of the MIDI protocol.
This is a bug in Bitwig.
And changing this setting might introduce regressions in other programs
that rely on the size of the raw MIDI data.
> + vmidi->parser->nostat = 1;
> vmidi->seq_mode = rdev->seq_mode;
The patch formatting is still broken.
And please read Documentation/SubmittingPatches,
Regards,
Clemens
next prev parent reply other threads:[~2014-05-07 20:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-07 17:44 [PATCH]: snd_seq_virmidi.c do not use running status for virmidi raw input Ralf Beck
2014-05-07 20:41 ` Clemens Ladisch [this message]
2014-05-08 6:00 ` Ralf Beck
2014-05-08 20:08 ` Clemens Ladisch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=536A9A70.4020401@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=ralfbeck1@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox