From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars-Peter Clausen Subject: Re: [PATCH v4 2/5] ASoC: Move standard kcontrol helpers to the component level Date: Sat, 10 May 2014 11:28:59 +0200 Message-ID: <536DF15B.50409@metafoo.de> References: <1398165797-22997-3-git-send-email-lars@metafoo.de> <20140509150034.GH2870@dragon> <536CF16F.8010807@metafoo.de> <536CFBE7.3070805@metafoo.de> <20140510050747.GI2870@dragon> <536DCF6F.9020507@metafoo.de> <536DD108.2090607@metafoo.de> <20140510083131.GL2870@dragon> <536DE548.9050008@metafoo.de> <20140510091209.GM2870@dragon> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: Received: from smtp-out-016.synserver.de (smtp-out-075.synserver.de [212.40.185.75]) by alsa0.perex.cz (Postfix) with ESMTP id ED976261ADB for ; Sat, 10 May 2014 11:29:00 +0200 (CEST) In-Reply-To: <20140510091209.GM2870@dragon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Shawn Guo Cc: Dimitris Papastamos , "alsa-devel@alsa-project.org" , patches@opensource.wolfsonmicro.com, Liam Girdwood , Mark Brown , Charles Keepax , Fabio Estevam List-Id: alsa-devel@alsa-project.org On 05/10/2014 11:12 AM, Shawn Guo wrote: > On Sat, May 10, 2014 at 10:37:28AM +0200, Lars-Peter Clausen wrote: >> On 05/10/2014 10:31 AM, Shawn Guo wrote: >>> On Sat, May 10, 2014 at 09:11:04AM +0200, Lars-Peter Clausen wrote: >>>> On 05/10/2014 09:04 AM, Lars-Peter Clausen wrote: >>>> [..] >>>>>> The error message only shows up with Debian wheezy and does not with >>>>>> yocto rootfs. And even when the error message shows, the audio still >>>>>> functions well on Debian wheezy. So it's just a noisy error message >>>>>> for me which is only seen after your kernel patch. >>>>> >>>>> The keyword here is "seen". The error quite likely predated the commit, but >>>>> it was silently discarded. >>>>> >>>>> regmap_read() returns -EBUSY when there is no cached register value and >>>>> cache_only is set to true. But I'm not sure why that would happen, try to >>>>> add some printks to _regmap_read() to see if this is the source and if it is >>>>> why it is. >>>> >>>> Both SGTL5000_CHIP_ANA_ADC_CTRL and SGTL5000_CHIP_MIC_CTRL don't >>>> have an entry in sgtl5000_reg_defaults. So if cache_only is true, >>>> controls which use these registers will return -EBUSY when you try >>>> to read or write them. >>> >>> Hmm, it's a wm8962 than sgtl5000 on board imx6q-sabresd. >> >> Ok, misread the boardname. But the issue will be the same. >> cache_only = true and trying to read/update a register that is not >> in the cache. > > Yea, you're right. When the error message shows up, _regmap_read() > returns -EBUSY for reg WM8962_CLASS_D_CONTROL_1. But how do I find out > why the reg is not in the cache? The register is marked as volatile in the driver and volatile registers are never cached. I don't know what the right fix is in this case though. - Lars