From: Tomasz Figa <t.figa@samsung.com>
To: Vasily Khoruzhick <anarsoul@gmail.com>
Cc: "Liam Girdwood" <lgirdwood@gmail.com>,
"Mark Brown" <broonie@kernel.org>,
alsa-devel@alsa-project.org, "Kukjin Kim" <kgene.kim@samsung.com>,
"Sangbeom Kim" <sbkim73@samsung.com>,
"Lars-Peter Clausen" <lars@metafoo.de>,
"linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"Heiko Stübner" <heiko@sntech.de>
Subject: Re: [alsa-devel] [PATCH v2 1/2] ASoC: samsung: s3c24{xx, 12}-i2s: port to use generic dmaengine API
Date: Wed, 21 May 2014 17:07:47 +0200 [thread overview]
Message-ID: <537CC143.9050307@samsung.com> (raw)
In-Reply-To: <CA+E=qVd_M5wes5rwU0pkR7-4FDS8J-XKfajV7-efTtm=sy2==g@mail.gmail.com>
On 21.05.2014 16:53, Vasily Khoruzhick wrote:
> On Wed, May 21, 2014 at 4:28 PM, Tomasz Figa <t.figa@samsung.com> wrote:
>> Hi Vasily,
>
> Hi Tomasz,
>
>> Please remember to keep linux-samsung-soc ML on Cc when sending patches
>> related to Samsung platforms. It is essential to let Samsung people
>> review them.
>
> Ok, I'll keep it in mind. I've just checked and get_maintainer.pl
> outputs linux-samsung-soc ML for these
> patches. I've omitted it occasionally, because it wasn't necessary to
> keep it in CC back in 2011
> (year of my last sound-related patch for s3c24xx).
>
>> Please resend the series with this in mind.
>
> Is it really necessary? This patch is supposed to go through ASoC
> tree, not through Samsung's.
> And I really doubt that Samsung guys test kernel for s3c24xx boards nowadays.
Maybe not test, but at least review the code. Also there might be other
people following that list that might be interested in looking at this
series, while not subscribed to alsa-devel - I can name at least Heiko
Stübner, who should be able to test it on further s3c24xx-based boards.
>
>> The patch in general looks good to me. Might be a good idea to specify
>> on what board(s) and how it was tested, though.
>
> It was tested on s3c2410-based iPAQ h1940, s3c2412 part was only
> compile-tested, as I don't have s3c2412 hardware.
OK, thanks.
Best regards,
Tomasz
next prev parent reply other threads:[~2014-05-21 15:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-20 20:26 [PATCH v2 1/2] ASoC: samsung: s3c24{xx, 12}-i2s: port to use generic dmaengine API Vasily Khoruzhick
2014-05-20 20:26 ` [PATCH v2 2/2] ASoC: samsung: drop support for legacy S3C24XX DMA API Vasily Khoruzhick
2014-05-20 22:19 ` [PATCH v2 1/2] ASoC: samsung: s3c24{xx, 12}-i2s: port to use generic dmaengine API Mark Brown
2014-05-21 6:42 ` Vasily Khoruzhick
2014-05-21 10:49 ` Mark Brown
2014-05-21 10:53 ` Vasily Khoruzhick
2014-05-21 13:28 ` [alsa-devel] " Tomasz Figa
2014-05-21 14:53 ` Vasily Khoruzhick
2014-05-21 15:07 ` Tomasz Figa [this message]
2014-05-21 15:20 ` Vasily Khoruzhick
2014-05-21 15:29 ` Heiko Stübner
2014-05-21 15:39 ` Vasily Khoruzhick
2014-05-21 15:56 ` Heiko Stübner
2014-05-21 16:09 ` Vasily Khoruzhick
2014-05-21 16:20 ` Mark Brown
2014-05-21 16:24 ` Heiko Stübner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=537CC143.9050307@samsung.com \
--to=t.figa@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=anarsoul@gmail.com \
--cc=broonie@kernel.org \
--cc=heiko@sntech.de \
--cc=kgene.kim@samsung.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=sbkim73@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).