From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Lars-Peter Clausen <lars@metafoo.de>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Cc: Fabio Baltieri <fabio.baltieri@linaro.org>,
alsa-devel@alsa-project.org,
Jarkko Nikula <jarkko.nikula@bitmer.com>,
Stephen Warren <swarren@wwwdotorg.org>
Subject: Re: [PATCH 3/4] ASoC: davinci-evm: Replace instances of rtd->codec->card with rtd->card
Date: Mon, 26 May 2014 10:08:30 +0300 [thread overview]
Message-ID: <5382E86E.3050000@ti.com> (raw)
In-Reply-To: <1400492508-2732-3-git-send-email-lars@metafoo.de>
On 05/19/2014 12:41 PM, Lars-Peter Clausen wrote:
> No need to go via the CODEC to get a pointer to the card. This will help to
> eventually remove the card field from the snd_soc_codec struct.
>
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
> sound/soc/davinci/davinci-evm.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/davinci/davinci-evm.c b/sound/soc/davinci/davinci-evm.c
> index cab98a5..a50010e 100644
> --- a/sound/soc/davinci/davinci-evm.c
> +++ b/sound/soc/davinci/davinci-evm.c
> @@ -38,7 +38,7 @@ struct snd_soc_card_drvdata_davinci {
> static int evm_startup(struct snd_pcm_substream *substream)
> {
> struct snd_soc_pcm_runtime *rtd = substream->private_data;
> - struct snd_soc_card *soc_card = rtd->codec->card;
> + struct snd_soc_card *soc_card = rtd->card;
> struct snd_soc_card_drvdata_davinci *drvdata =
> snd_soc_card_get_drvdata(soc_card);
>
> @@ -51,7 +51,7 @@ static int evm_startup(struct snd_pcm_substream *substream)
> static void evm_shutdown(struct snd_pcm_substream *substream)
> {
> struct snd_soc_pcm_runtime *rtd = substream->private_data;
> - struct snd_soc_card *soc_card = rtd->codec->card;
> + struct snd_soc_card *soc_card = rtd->card;
> struct snd_soc_card_drvdata_davinci *drvdata =
> snd_soc_card_get_drvdata(soc_card);
>
> @@ -65,8 +65,7 @@ static int evm_hw_params(struct snd_pcm_substream *substream,
> struct snd_soc_pcm_runtime *rtd = substream->private_data;
> struct snd_soc_dai *codec_dai = rtd->codec_dai;
> struct snd_soc_dai *cpu_dai = rtd->cpu_dai;
> - struct snd_soc_codec *codec = rtd->codec;
> - struct snd_soc_card *soc_card = codec->card;
> + struct snd_soc_card *soc_card = rtd->card;
> int ret = 0;
> unsigned sysclk = ((struct snd_soc_card_drvdata_davinci *)
> snd_soc_card_get_drvdata(soc_card))->sysclk;
> @@ -125,7 +124,7 @@ static int evm_aic3x_init(struct snd_soc_pcm_runtime *rtd)
> {
> struct snd_soc_card *card = rtd->card;
> struct snd_soc_codec *codec = rtd->codec;
> - struct device_node *np = codec->card->dev->of_node;
> + struct device_node *np = card->dev->of_node;
> int ret;
>
> /* Add davinci-evm specific widgets */
>
--
Péter
next prev parent reply other threads:[~2014-05-26 7:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-19 9:41 [PATCH 1/4] ASoC: tegra: Replace instances of rtd->codec->card with rtd->card Lars-Peter Clausen
2014-05-19 9:41 ` [PATCH 2/4] ASoC: omap: " Lars-Peter Clausen
2014-05-20 4:40 ` Jarkko Nikula
2014-05-20 21:55 ` Mark Brown
2014-05-19 9:41 ` [PATCH 3/4] ASoC: davinci-evm: " Lars-Peter Clausen
2014-05-26 7:08 ` Peter Ujfalusi [this message]
2014-05-26 15:35 ` Mark Brown
2014-05-19 9:41 ` [PATCH 4/4] ASoC: mop500_ab8500: " Lars-Peter Clausen
2014-05-20 21:55 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5382E86E.3050000@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=fabio.baltieri@linaro.org \
--cc=jarkko.nikula@bitmer.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox