From: Lars-Peter Clausen <lars@metafoo.de>
To: Vinod Koul <vinod.koul@intel.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
broonie@kernel.org, Kp Jeeja <jeeja.kp@intel.com>,
"Subhransu S. Prusty" <subhransu.s.prusty@intel.com>
Subject: Re: [PATCH v2 1/2] ASoC: export dapm_kcontrol_set/get_value functions
Date: Fri, 30 May 2014 14:50:10 +0200 [thread overview]
Message-ID: <53887E82.9030508@metafoo.de> (raw)
In-Reply-To: <20140530102944.GP21128@intel.com>
On 05/30/2014 12:29 PM, Vinod Koul wrote:
[...]
>> Btw. in this case I think you should just use the default DAPM
>> kcontrol put callback. There doesn't seem to be anything special in
>> here and with the DAPM componentization series the default handler
>> is also able to handle platforms.
> Not for this version sure, but future platforms of our need some custom stuff to
> be done. I will try to minimize those ones and once your component work is
> complete redo these bits. Would be too happy to remove if it works out that way,
> which is not the case with today. So till then we need these bits and exporting
> of the dapm_kcontrol_set_value()
>
You do not need to call dapm_kcontrol_set_value() from your custom put
handler unless the control is auto-muted or a virtual control, of which
neither seems to be the case here. So we do not need to export the function.
- Lars
next prev parent reply other threads:[~2014-05-30 12:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 10:03 [PATCH v2 1/2] ASoC: export dapm_kcontrol_set/get_value functions Vinod Koul
2014-05-29 10:03 ` [PATCH v2 2/2] ASoC: dapm: Add a helper to get the platform for DAPM kcontrol Vinod Koul
2014-06-01 19:28 ` Mark Brown
2014-05-29 10:55 ` [PATCH v2 1/2] ASoC: export dapm_kcontrol_set/get_value functions Lars-Peter Clausen
2014-05-30 6:09 ` Vinod Koul
2014-05-30 7:22 ` Lars-Peter Clausen
2014-05-30 10:29 ` Vinod Koul
2014-05-30 12:50 ` Lars-Peter Clausen [this message]
2014-06-01 19:26 ` Mark Brown
2014-06-03 5:44 ` Vinod Koul
2014-06-03 10:11 ` Mark Brown
2014-06-06 5:54 ` Vinod Koul
2014-06-06 9:51 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53887E82.9030508@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=jeeja.kp@intel.com \
--cc=lgirdwood@gmail.com \
--cc=peter.ujfalusi@ti.com \
--cc=subhransu.s.prusty@intel.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox