Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Qiao Zhou <zhouqiao@marvell.com>
To: "lgirdwood@gmail.com" <lgirdwood@gmail.com>,
	"broonie@kernel.org" <broonie@kernel.org>,
	"perex@perex.cz" <perex@perex.cz>,
	"tiwai@suse.de" <tiwai@suse.de>,
	"zhangfei.gao@gmail.com" <zhangfei.gao@gmail.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ASoC: pcm: fix dpcm_path_put in dpcm runtime update
Date: Thu, 12 Jun 2014 14:52:03 +0800	[thread overview]
Message-ID: <53994E13.4020800@marvell.com> (raw)
In-Reply-To: <1401882126-26225-1-git-send-email-zhouqiao@marvell.com>

On 06/04/2014 07:42 PM, Qiao Zhou wrote:
> we need to release dapm widget list after dpcm_path_get in
> soc_dpcm_runtime_update. otherwise, there will be potential memory
> leak. add dpcm_path_put to fix it.
>
> Signed-off-by: Qiao Zhou <zhouqiao@marvell.com>
> ---
>   sound/soc/soc-pcm.c |    1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/sound/soc/soc-pcm.c b/sound/soc/soc-pcm.c
> index a391de0..3bb8b80 100644
> --- a/sound/soc/soc-pcm.c
> +++ b/sound/soc/soc-pcm.c
> @@ -2072,6 +2072,7 @@ int soc_dpcm_runtime_update(struct snd_soc_card *card)
>   			dpcm_be_disconnect(fe, SNDRV_PCM_STREAM_PLAYBACK);
>   		}
>
> +		dpcm_path_put(&list);
>   capture:
>   		/* skip if FE doesn't have capture capability */
>   		if (!fe->cpu_dai->driver->capture.channels_min)
>
Hi Maintainers,

Do you have any comments? Thanks.

-- 

Best Regards
Qiao

  reply	other threads:[~2014-06-12  6:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-04 11:42 [PATCH] ASoC: pcm: fix dpcm_path_put in dpcm runtime update Qiao Zhou
2014-06-12  6:52 ` Qiao Zhou [this message]
2014-06-21 10:30 ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53994E13.4020800@marvell.com \
    --to=zhouqiao@marvell.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    --cc=zhangfei.gao@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox