alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Jaroslav Kysela <perex@perex.cz>
To: "Alexander E. Patrakov" <patrakov@gmail.com>,
	alsa-devel@alsa-project.org
Subject: Re: pcm: Add missing callbacks that cannot be NULL
Date: Fri, 13 Jun 2014 09:14:55 +0200	[thread overview]
Message-ID: <539AA4EF.7000001@perex.cz> (raw)
In-Reply-To: <1402569264-2789-1-git-send-email-patrakov@gmail.com>

Date 12.6.2014 12:34, Alexander E. Patrakov wrote:
> Some plugins don't implement some mandatory fast_ops. Thus, these
> fast_ops get defaulted to NULL, and programs crash when calling the
> corresponding snd_pcm_* functions.
> 
> The following callbacks were missing:
> 
> file: htimestamp
> multi: rewindable, forwardable
> null: rewindable, forwardable

I applied above three patches. Thanks.

> rate: rewindable, forwardable

A comment sent.

                                        Jaroslav

-- 
Jaroslav Kysela <perex@perex.cz>
Linux Kernel Sound Maintainer
ALSA Project; Red Hat, Inc.

      parent reply	other threads:[~2014-06-13  7:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-12 10:34 pcm: Add missing callbacks that cannot be NULL Alexander E. Patrakov
2014-06-12 10:34 ` [PATCH 1/4] pcm:file: add the missing htimestamp callback Alexander E. Patrakov
2014-06-12 10:34 ` [PATCH 2/4] pcm: rate: add rewindable and forwardable callbacks Alexander E. Patrakov
2014-06-13  7:13   ` Jaroslav Kysela
2014-06-13  8:44     ` Alexander E. Patrakov
2014-06-13  9:19       ` Jaroslav Kysela
2014-06-13  9:46         ` Alexander E. Patrakov
2014-06-12 10:34 ` [PATCH 3/4] pcm: multi: implement " Alexander E. Patrakov
2014-06-12 10:34 ` [PATCH 4/4] pcm: null: add " Alexander E. Patrakov
2014-06-13  7:14 ` Jaroslav Kysela [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=539AA4EF.7000001@perex.cz \
    --to=perex@perex.cz \
    --cc=alsa-devel@alsa-project.org \
    --cc=patrakov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).