From: "Alexander E. Patrakov" <patrakov@gmail.com>
To: Jaroslav Kysela <perex@perex.cz>
Cc: ALSA development <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 2/4] pcm: rate: add rewindable and forwardable callbacks
Date: Fri, 13 Jun 2014 15:46:35 +0600 [thread overview]
Message-ID: <539AC87B.5090005@gmail.com> (raw)
In-Reply-To: <539AC235.3050400@perex.cz>
13.06.2014 15:19, Jaroslav Kysela wrote:
> I see, I agree that the current code is/was tricky and probably broken
> as you noted.
>
> But along with your patch, the code in rewind/forward callbacks should
> be also removed. I put yours and this patch to the alsa-lib repository:
>
> http://git.alsa-project.org/?p=alsa-lib.git;a=commit;h=5256e150eb34cf599e79839feaff7398ed67a499
Thanks, that's indeed a logical step.
--
Alexander E. Patrakov
next prev parent reply other threads:[~2014-06-13 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-12 10:34 pcm: Add missing callbacks that cannot be NULL Alexander E. Patrakov
2014-06-12 10:34 ` [PATCH 1/4] pcm:file: add the missing htimestamp callback Alexander E. Patrakov
2014-06-12 10:34 ` [PATCH 2/4] pcm: rate: add rewindable and forwardable callbacks Alexander E. Patrakov
2014-06-13 7:13 ` Jaroslav Kysela
2014-06-13 8:44 ` Alexander E. Patrakov
2014-06-13 9:19 ` Jaroslav Kysela
2014-06-13 9:46 ` Alexander E. Patrakov [this message]
2014-06-12 10:34 ` [PATCH 3/4] pcm: multi: implement " Alexander E. Patrakov
2014-06-12 10:34 ` [PATCH 4/4] pcm: null: add " Alexander E. Patrakov
2014-06-13 7:14 ` pcm: Add missing callbacks that cannot be NULL Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=539AC87B.5090005@gmail.com \
--to=patrakov@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).