From: Lars-Peter Clausen <lars@metafoo.de>
To: Rajeev kumar <rajeev-dlh.kumar@st.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"broonie@kernel.org" <broonie@kernel.org>,
"spk.linux@gmail.com" <spk.linux@gmail.com>,
Sachin Kamat <sachin.kamat@samsung.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>
Subject: Re: [PATCH 01/16] ASoC: cs4270: Remove redundant OOM message
Date: Fri, 20 Jun 2014 13:07:39 +0200 [thread overview]
Message-ID: <53A415FB.3060107@metafoo.de> (raw)
In-Reply-To: <53A4152C.2050702@st.com>
On 06/20/2014 01:04 PM, Rajeev kumar wrote:
> On 6/20/2014 3:28 PM, Sachin Kamat wrote:
>> Let memory subsystem handle the error logging.
>>
>> Signed-off-by: Sachin Kamat <sachin.kamat@samsung.com>
>> ---
>> sound/soc/codecs/cs4270.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/sound/soc/codecs/cs4270.c b/sound/soc/codecs/cs4270.c
>> index 9947a9583679..e6d4ff9fd992 100644
>> --- a/sound/soc/codecs/cs4270.c
>> +++ b/sound/soc/codecs/cs4270.c
>> @@ -664,10 +664,8 @@ static int cs4270_i2c_probe(struct i2c_client
>> *i2c_client,
>>
>> cs4270 = devm_kzalloc(&i2c_client->dev, sizeof(struct cs4270_private),
>> GFP_KERNEL);
>> - if (!cs4270) {
>> - dev_err(&i2c_client->dev, "could not allocate codec\n");
>
> You are just removing a information which are required in error condition.
> In my view it should be here..
devm_kzalloc already prints a error message when the allocation fails.
next prev parent reply other threads:[~2014-06-20 11:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-20 9:58 [PATCH 01/16] ASoC: cs4270: Remove redundant OOM message Sachin Kamat
2014-06-20 9:58 ` [PATCH 02/16] ASoC: cs42l73: " Sachin Kamat
2014-06-20 14:48 ` Handrigan, Paul
2014-06-27 11:48 ` Mark Brown
2014-06-20 9:58 ` [PATCH 03/16] ASoC: sgtl5000: " Sachin Kamat
2014-06-20 9:59 ` [PATCH 04/16] ASoC: sta529: " Sachin Kamat
2014-06-20 9:59 ` [PATCH 05/16] ASoC: tlv320aic3x: " Sachin Kamat
2014-06-20 9:59 ` [PATCH 06/16] ASoC: tpa6130a2: " Sachin Kamat
2014-06-20 9:59 ` [PATCH 07/16] ASoC: twl4030: " Sachin Kamat
2014-06-20 9:59 ` [PATCH 08/16] ASoC: wl1273: " Sachin Kamat
2014-06-20 9:59 ` [PATCH 09/16] ASoC: wm0010: " Sachin Kamat
2014-06-20 14:59 ` Charles Keepax
2014-06-20 9:59 ` [PATCH 10/16] ASoC: wm1250-ev1: " Sachin Kamat
2014-06-20 15:00 ` Charles Keepax
2014-06-20 9:59 ` [PATCH 11/16] ASoC: wm2000: " Sachin Kamat
2014-06-20 15:01 ` Charles Keepax
2014-06-20 9:59 ` [PATCH 12/16] ASoC: wm8904: " Sachin Kamat
2014-06-20 15:04 ` Charles Keepax
2014-06-20 9:59 ` [PATCH 13/16] ASoC: wm8958: " Sachin Kamat
2014-06-20 15:05 ` Charles Keepax
2014-06-20 9:59 ` [PATCH 14/16] ASoC: wm8994: " Sachin Kamat
2014-06-20 15:06 ` Charles Keepax
2014-06-20 9:59 ` [PATCH 15/16] ASoC: wm9090: " Sachin Kamat
2014-06-20 15:06 ` Charles Keepax
2014-06-20 9:59 ` [PATCH 16/16] ASoC: wm_hubs: " Sachin Kamat
2014-06-20 15:06 ` Charles Keepax
2014-06-20 11:04 ` [PATCH 01/16] ASoC: cs4270: " Rajeev kumar
2014-06-20 11:07 ` Lars-Peter Clausen [this message]
2014-06-20 14:50 ` Handrigan, Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53A415FB.3060107@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=rajeev-dlh.kumar@st.com \
--cc=sachin.kamat@samsung.com \
--cc=spk.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox