Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: "Roc Vallès" <vallesroc@gmail.com>,
	"Elimar Riesebieter" <riesebie@lxtec.de>,
	"Jordi Mallach" <jordi@debian.org>,
	"Takashi Iwai" <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: alsa-tools 1.0.28 regression with sblive/emu10k1: init_live shell script broken.
Date: Wed, 25 Jun 2014 18:57:46 +0200	[thread overview]
Message-ID: <53AAFF8A.5060809@ladisch.de> (raw)
In-Reply-To: <CAPq5wtZVZpYvBJ2TK-oG5kEbfc95bz4_nVKxzcWXwGXWnWHQgw@mail.gmail.com>

Roc Vallès wrote:
> I've recently upgraded to alsa-tools 1.0.28. There's apparently a
> regression: live_init, the script that is bundled for sound blaster
> live soundcard initialization, has been broken.
>
> # /usr/bin/init_live
> /usr/bin/init_live: line 49: log: command not found
> /usr/bin/init_live: line 51: local: can only be used in a function
> ...

Broken by the patch below.  Where are the parentheses?


    commit a17282503f4ceb62f66eb5a28726fd096af0a70b
    Author: Elimar Riesebieter <riesebie@lxtec.de>
    Date:   Wed May 15 19:19:07 2013 +0200

    Fix bashisms.

    The "€œfunction"€ builtin is a bashism that can be simply omitted with
    no behaviour change, if parentheses are supplied.

    Signed-off-by: Jordi Mallach <jordi@debian.org>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>

    diff --git a/ld10k1/setup/init_live.in b/ld10k1/setup/init_live.in
    index 70d30c8..5e6580f 100644
    --- a/ld10k1/setup/init_live.in
    +++ b/ld10k1/setup/init_live.in
    @@ -46,7 +46,7 @@ std_playback=playback
     std_capture=capture
     #std_capture=capture_noswitch

    -function log
    +log
     {
         local level=$1
    ...


Regards,
Clemens
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2014-06-25 16:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-25 16:37 alsa-tools 1.0.28 regression with sblive/emu10k1: init_live shell script broken Roc Vallès
2014-06-25 16:57 ` Clemens Ladisch [this message]
2014-06-27 14:50   ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2014-06-25 16:10 Roc Vallès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53AAFF8A.5060809@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=jordi@debian.org \
    --cc=riesebie@lxtec.de \
    --cc=tiwai@suse.de \
    --cc=vallesroc@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox