From: Lars-Peter Clausen <lars@metafoo.de>
To: bardliao@realtek.com, broonie@kernel.org, lgirdwood@gmail.com
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org, flove@realtek.com
Subject: Re: [PATCH] ASoC: rt5640: add ASRC support
Date: Fri, 27 Jun 2014 16:05:14 +0200 [thread overview]
Message-ID: <53AD7A1A.2090501@metafoo.de> (raw)
In-Reply-To: <1403866691-5031-1-git-send-email-bardliao@realtek.com>
On 06/27/2014 12:58 PM, bardliao@realtek.com wrote:
> From: Bard Liao <bardliao@realtek.com>
>
> This patch add ASRC support for rt5640 series codecs.
>
> Signed-off-by: Bard Liao <bardliao@realtek.com>
> ---
> sound/soc/codecs/rt5640.c | 79 ++++++++++++++++++++++++++++++++++++++++++++++-
> sound/soc/codecs/rt5640.h | 2 ++
> 2 files changed, 80 insertions(+), 1 deletion(-)
>
> diff --git a/sound/soc/codecs/rt5640.c b/sound/soc/codecs/rt5640.c
> index 6bc6efd..3245ec4 100644
> --- a/sound/soc/codecs/rt5640.c
> +++ b/sound/soc/codecs/rt5640.c
> @@ -341,6 +341,43 @@ static bool rt5640_readable_register(struct device *dev, unsigned int reg)
> }
> }
>
> +static const char * const rt5640_asrc_mode[] = {
> + "disable", "enable"
> +};
> +
> +static const SOC_ENUM_SINGLE_DECL(rt5640_asrc_enum, SND_SOC_NOPM,
> + 0, rt5640_asrc_mode);
I wonder if that shouldn't be something that is automatically
enabled/disabled based on the samplerates involved. Also for enable/disable
controls use a switch control rather than a enum.
- Lars
next prev parent reply other threads:[~2014-06-27 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-27 10:58 [PATCH] ASoC: rt5640: add ASRC support bardliao
2014-06-27 14:05 ` Lars-Peter Clausen [this message]
2014-06-30 6:09 ` Bard Liao
2014-06-30 10:45 ` Lars-Peter Clausen
2014-06-30 14:50 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53AD7A1A.2090501@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=flove@realtek.com \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox