From: Lars-Peter Clausen <lars@metafoo.de>
To: Huang Tao <huangtao@rock-chips.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>
Subject: Re: [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller
Date: Tue, 01 Jul 2014 16:57:07 +0200 [thread overview]
Message-ID: <53B2CC43.5090309@metafoo.de> (raw)
In-Reply-To: <53B2CA5E.1060401@rock-chips.com>
On 07/01/2014 04:49 PM, Huang Tao wrote:
> Dear Lars:
>
> 于 2014年07月01日 17:51, Lars-Peter Clausen 写道:
>>> + /* Try to set the I2S Channel id from dt */
>>> >+ pdev->id = of_alias_get_id(np, "i2s");
>>> >+ dev_set_name(&pdev->dev, "%s.%d",
>>> >+ pdev->dev.driver->name,
>>> >+ pdev->id);
>> A device should not change its id or name.
>>
> Could you tell me the reason?
>
When registering a device the Linux device core that the id and name are
unique. If you change them behind the back of the core there is no guarantee
that they are still unique and undefined behavior might occur. Also changing
them can cause all kind of other weird behavior, e.g. the name no longer
matches the name of the sysfs files, etc.
- Lars
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2014-07-01 14:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 8:37 [PATCH 0/2] add rockchip i2s driver jianqun
[not found] ` <1404203860-30712-1-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-01 8:37 ` [PATCH 1/2] ASoC: dt-bindings: add rockchip i2s bindings jianqun
[not found] ` <1404203860-30712-2-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-01 8:54 ` Mark Rutland
2014-07-01 10:08 ` jianqun
2014-07-04 7:26 ` [PATCH v2 " jianqun
[not found] ` <1404458796-6818-1-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-04 16:55 ` Mark Rutland
2014-07-05 11:10 ` [PATCH v3 " jianqun
[not found] ` <1404558638-1739-1-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-09 7:40 ` Mark Brown
2014-07-01 8:47 ` [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller jianqun
[not found] ` <1404204458-30881-1-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-01 9:01 ` Mark Rutland
2014-07-01 9:51 ` [alsa-devel] " Lars-Peter Clausen
[not found] ` <53B2CA5E.1060401@rock-chips.com>
2014-07-01 14:57 ` Lars-Peter Clausen [this message]
2014-07-01 15:17 ` Huang Tao
2014-07-01 17:07 ` Mark Brown
2014-07-02 1:01 ` Huang Tao
[not found] ` <53B359FD.3080809-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-02 10:23 ` Mark Brown
2014-07-02 10:57 ` Jianqun
2014-07-02 11:16 ` Mark Brown
2014-07-04 7:29 ` [PATCH v2 " jianqun
2014-07-05 11:13 ` [PATCH v3 " jianqun
-- strict thread matches above, loose matches on Subject: below --
2014-07-01 8:39 [PATCH " jianqun
[not found] ` <1404203972-30760-1-git-send-email-xjq-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2014-07-01 9:32 ` Varka Bhadram
[not found] ` <53B28029.90408-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-07-01 10:11 ` Heiko Stübner
2014-07-11 9:54 [PATCH 0/2] add rockchip i2s driver jianqun
2014-07-11 9:58 ` [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller jianqun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B2CC43.5090309@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=huangtao@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).