From: Benoit Cousson <bcousson@baylibre.com>
To: Mark Brown <broonie@kernel.org>
Cc: misael.lopez@ti.com, lars@metafoo.de, lgirdwood@gmail.com,
alsa-devel@alsa-project.org
Subject: Re: [PATCH v4 2/8] ASoC: pcm: Refactor soc_pcm_apply_msb for multicodecs
Date: Tue, 01 Jul 2014 19:31:28 +0200 [thread overview]
Message-ID: <53B2F070.8010706@baylibre.com> (raw)
In-Reply-To: <20140701172053.GC15028@sirena.org.uk>
On 01/07/2014 19:20, Mark Brown wrote:
> On Tue, Jul 01, 2014 at 09:47:55AM +0200, Benoit Cousson wrote:
>> Refactor the function to facilitate the migration to
>> multiple codecs.
>
> Applied, thanks.
>
>> Fix a trailing space in the header as well.
>
> Please don't do things like this if they're not in a part of the code
> being changed, it makes review a bit harder. A separate patch would be
> fine.
OK, sorry about that. I'll not do it again.
Thanks,
Benoit
--
Benoît Cousson
BayLibre
Embedded Linux Technology Lab
www.baylibre.com
next prev parent reply other threads:[~2014-07-01 17:31 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-01 7:47 [PATCH v4 0/8] ASoC: core: Add support for DAI multicodec Benoit Cousson
2014-07-01 7:47 ` [PATCH v4 1/8] ASoC: core: Change soc_link_dai_widgets signature for multiple codecs Benoit Cousson
2014-07-01 17:17 ` Mark Brown
2014-07-04 16:13 ` Benoit Cousson
2014-07-04 16:51 ` Mark Brown
2014-07-01 7:47 ` [PATCH v4 2/8] ASoC: pcm: Refactor soc_pcm_apply_msb for multicodecs Benoit Cousson
2014-07-01 17:20 ` Mark Brown
2014-07-01 17:31 ` Benoit Cousson [this message]
2014-07-01 7:47 ` [PATCH v4 3/8] ASoC: core: Add initial support for DAI multicodec Benoit Cousson
2014-07-01 13:19 ` Lars-Peter Clausen
2014-07-01 17:27 ` Benoit Cousson
2014-07-01 7:47 ` [PATCH v4 4/8] ASoC: pcm: Add " Benoit Cousson
2014-07-01 13:32 ` Lars-Peter Clausen
2014-07-01 7:47 ` [PATCH v4 5/8] ASoC: dapm: " Benoit Cousson
2014-07-01 13:40 ` Lars-Peter Clausen
2014-07-01 7:47 ` [PATCH v4 6/8] ASoC: compress: " Benoit Cousson
2014-07-01 13:49 ` Lars-Peter Clausen
2014-07-01 16:25 ` Vinod Koul
2014-07-01 16:42 ` Lars-Peter Clausen
2014-07-01 16:45 ` Vinod Koul
2014-07-01 17:32 ` Benoit Cousson
2014-07-01 16:41 ` Vinod Koul
2014-07-01 17:41 ` Mark Brown
2014-07-03 6:39 ` Vinod Koul
2014-07-02 12:53 ` Benoit Cousson
2014-07-03 6:41 ` Vinod Koul
2014-07-03 11:09 ` Benoit Cousson
2014-07-03 11:16 ` Mark Brown
2014-07-03 11:20 ` Lars-Peter Clausen
2014-07-03 11:39 ` Benoit Cousson
2014-07-03 11:43 ` Lars-Peter Clausen
2014-07-03 11:46 ` Benoit Cousson
2014-07-03 12:06 ` Vinod Koul
2014-07-03 12:18 ` Mark Brown
2014-07-03 16:15 ` Vinod Koul
2014-07-03 18:23 ` Lars-Peter Clausen
2014-07-04 13:55 ` Benoit Cousson
2014-07-03 18:38 ` Mark Brown
2014-07-03 19:09 ` Pierre-Louis Bossart
2014-07-01 7:48 ` [PATCH v4 7/8] ASoC: pcm: Add soc_dai_hw_params helper Benoit Cousson
2014-07-01 13:43 ` Lars-Peter Clausen
2014-07-01 7:48 ` [PATCH v4 8/8] ASoC: core: Add a warning for link_dai_widget in the multicodec case Benoit Cousson
2014-07-01 13:41 ` Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B2F070.8010706@baylibre.com \
--to=bcousson@baylibre.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=misael.lopez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).