From: Lars-Peter Clausen <lars@metafoo.de>
To: Benoit Cousson <bcousson@baylibre.com>,
broonie@kernel.org, lgirdwood@gmail.com
Cc: Fabien Parent <fparent@baylibre.com>,
misael.lopez@ti.com, alsa-devel@alsa-project.org
Subject: Re: [PATCH v5 2/5] ASoC: pcm: Add support for DAI multicodec
Date: Sun, 06 Jul 2014 16:18:24 +0200 [thread overview]
Message-ID: <53B95AB0.8070307@metafoo.de> (raw)
In-Reply-To: <1404490075-24997-3-git-send-email-bcousson@baylibre.com>
On 07/04/2014 06:07 PM, Benoit Cousson wrote:
[...]
> */
> bool snd_soc_runtime_ignore_pmdown_time(struct snd_soc_pcm_runtime *rtd)
> {
> + int i;
> + bool ignore = true;
> +
> if (!rtd->pmdown_time || rtd->dai_link->ignore_pmdown_time)
> return true;
>
> - return rtd->cpu_dai->component->ignore_pmdown_time &&
> - rtd->codec_dai->component->ignore_pmdown_time;
> + for (i = 0; (i < rtd->num_codecs) && !ignore; i++)
As you said last time this should be '&& ignore'. Or maybe just drop the
check altogether.
> + ignore &= rtd->codec_dais[i]->component->ignore_pmdown_time;
> +
> + return rtd->cpu_dai->component->ignore_pmdown_time && ignore;
> }
>
next prev parent reply other threads:[~2014-07-06 14:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-04 16:07 [PATCH v5 0/5] ASoC: core: Add support for DAI multicodec Benoit Cousson
2014-07-04 16:07 ` [PATCH v5 1/5] ASoC: core: Add initial " Benoit Cousson
2014-07-04 16:07 ` [PATCH v5 2/5] ASoC: pcm: Add " Benoit Cousson
2014-07-06 14:18 ` Lars-Peter Clausen [this message]
2014-07-06 20:23 ` Benoit Cousson
2014-07-04 16:07 ` [PATCH v5 3/5] ASoC: dapm: " Benoit Cousson
2014-07-04 16:07 ` [PATCH v5 4/5] ASoC: compress: Prevent multicodec for compressed stream Benoit Cousson
2014-07-07 8:50 ` Vinod Koul
2014-07-04 16:07 ` [PATCH v5 5/5] ASoC: pcm: Add soc_dai_hw_params helper Benoit Cousson
2014-07-06 14:16 ` [PATCH v5 0/5] ASoC: core: Add support for DAI multicodec Lars-Peter Clausen
2014-07-06 14:20 ` Lars-Peter Clausen
2014-07-06 20:49 ` Benoit Cousson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53B95AB0.8070307@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=bcousson@baylibre.com \
--cc=broonie@kernel.org \
--cc=fparent@baylibre.com \
--cc=lgirdwood@gmail.com \
--cc=misael.lopez@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox