From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, clemens@ladisch.de,
darrena092@gmail.com, ffado-devel@lists.sf.net
Subject: Re: [PATCH 4/6] bebob: Use different labels for digital input/output interfaces
Date: Mon, 21 Jul 2014 19:49:56 +0900 [thread overview]
Message-ID: <53CCF054.6090301@sakamocchi.jp> (raw)
In-Reply-To: <s5hppgznidn.wl%tiwai@suse.de>
(Jul 21 2014 18:58), Takashi Iwai wrote:
>> @@ -498,6 +498,8 @@ static int special_dig_in_iface_ctl_set(struct snd_kcontrol *kctl,
>> int err;
>>
>> id = uval->value.enumerated.item[0];
>> + if (id >= ARRAY_SIZE(special_dig_in_iface_labels))
>> + return 0;
>
> This should return an error.
>> @@ -571,6 +577,8 @@ static int special_dig_out_iface_ctl_set(struct snd_kcontrol *kctl,
>> int err;
>>
>> id = uval->value.enumerated.item[0];
>> + if (id >= ARRAY_SIZE(special_dig_out_iface_labels))
>> + return 0;
>
> Ditto.
Oops, exactly. I use -EINVAL for the error code. Thank you.
Takashi Sakamoto
o-takashi@sakamocchi.jp
next prev parent reply other threads:[~2014-07-21 10:50 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-20 4:50 [PATCH -next] ALSA: bebob: Fix missing unlock on error in special_clk_ctl_put() weiyj_lk
2014-07-20 7:51 ` Takashi Sakamoto
2014-07-21 2:09 ` [PATCH 0/6] bebob: Improvements for M-Audio specific operations Takashi Sakamoto
2014-07-21 2:10 ` [PATCH 1/6] bebob: Arrangement for critical section to be shorter Takashi Sakamoto
2014-07-21 2:10 ` [PATCH 2/6] bebob: Reducing function callers for simplicity Takashi Sakamoto
2014-07-21 2:10 ` [PATCH 3/6] bebob: Add dev_err() for debugging Takashi Sakamoto
2014-07-21 10:02 ` Takashi Iwai
2014-07-21 2:10 ` [PATCH 4/6] bebob: Use different labels for digital input/output interfaces Takashi Sakamoto
2014-07-21 9:58 ` Takashi Iwai
2014-07-21 10:49 ` Takashi Sakamoto [this message]
2014-07-21 2:10 ` [PATCH 5/6] bebob: Correction for return value of .put callback functions Takashi Sakamoto
2014-07-21 2:10 ` [PATCH 6/6] bebob: Arrangement for a control element to which two settings relate Takashi Sakamoto
2014-07-21 7:06 ` [PATCH 0/6] bebob: Improvements for M-Audio specific operations Takashi Iwai
2014-07-21 9:50 ` Takashi Sakamoto
2014-07-21 9:59 ` Takashi Iwai
2014-07-22 14:11 ` [PATCH 1/3] bebob: Fix a missing to unlock mutex in error handling case Takashi Sakamoto
2014-07-22 14:13 ` [PATCH 2/3] bebob: Use different labels for digital input/output Takashi Sakamoto
2014-07-22 14:13 ` [PATCH 3/3] bebob: Correction for return value of .put callback Takashi Sakamoto
2014-07-22 14:27 ` Takashi Sakamoto
2014-07-22 14:28 ` Takashi Iwai
2014-07-22 14:26 ` [PATCH 1/3] bebob: Fix a missing to unlock mutex in error handling case Takashi Iwai
2014-07-22 15:23 ` Takashi Sakamoto
2014-07-22 15:02 ` [PATCH] ALSA: bebob: Correction for return value of special_clk_ctl_put() in error Takashi Sakamoto
2014-07-22 15:37 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53CCF054.6090301@sakamocchi.jp \
--to=o-takashi@sakamocchi.jp \
--cc=alsa-devel@alsa-project.org \
--cc=clemens@ladisch.de \
--cc=darrena092@gmail.com \
--cc=ffado-devel@lists.sf.net \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox