From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org, linaro-kernel@lists.linaro.org,
Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH 1/2] ASoC: ssm2518: Convert to params_width()
Date: Thu, 31 Jul 2014 14:19:43 +0200 [thread overview]
Message-ID: <53DA345F.10105@metafoo.de> (raw)
In-Reply-To: <1406809099-18597-1-git-send-email-broonie@kernel.org>
On 07/31/2014 02:18 PM, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The CODEC doesn't care how data is laid out in memory.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
> ---
> sound/soc/codecs/ssm2518.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/ssm2518.c b/sound/soc/codecs/ssm2518.c
> index 56adb3e2def9..e8680bea5f86 100644
> --- a/sound/soc/codecs/ssm2518.c
> +++ b/sound/soc/codecs/ssm2518.c
> @@ -361,11 +361,11 @@ static int ssm2518_hw_params(struct snd_pcm_substream *substream,
> return -EINVAL;
>
> if (ssm2518->right_j) {
> - switch (params_format(params)) {
> - case SNDRV_PCM_FORMAT_S16_LE:
> + switch (params_width(params)) {
> + case 16:
> ctrl1 |= SSM2518_SAI_CTRL1_FMT_RJ_16BIT;
> break;
> - case SNDRV_PCM_FORMAT_S24_LE:
> + case 24:
> ctrl1 |= SSM2518_SAI_CTRL1_FMT_RJ_24BIT;
> break;
> default:
>
prev parent reply other threads:[~2014-07-31 12:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-31 12:18 [PATCH 1/2] ASoC: ssm2518: Convert to params_width() Mark Brown
2014-07-31 12:18 ` [PATCH 2/2] ASoC: ssm2602: " Mark Brown
2014-07-31 12:20 ` Lars-Peter Clausen
2014-07-31 12:19 ` Lars-Peter Clausen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53DA345F.10105@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=broonie@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linaro-kernel@lists.linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).