* [PATCH 1/2] ASoC: ssm2518: Convert to params_width()
@ 2014-07-31 12:18 Mark Brown
2014-07-31 12:18 ` [PATCH 2/2] ASoC: ssm2602: " Mark Brown
2014-07-31 12:19 ` [PATCH 1/2] ASoC: ssm2518: " Lars-Peter Clausen
0 siblings, 2 replies; 4+ messages in thread
From: Mark Brown @ 2014-07-31 12:18 UTC (permalink / raw)
To: Lars-Peter Clausen, Liam Girdwood; +Cc: alsa-devel, linaro-kernel, Mark Brown
From: Mark Brown <broonie@linaro.org>
The CODEC doesn't care how data is laid out in memory.
Signed-off-by: Mark Brown <broonie@linaro.org>
---
sound/soc/codecs/ssm2518.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/ssm2518.c b/sound/soc/codecs/ssm2518.c
index 56adb3e2def9..e8680bea5f86 100644
--- a/sound/soc/codecs/ssm2518.c
+++ b/sound/soc/codecs/ssm2518.c
@@ -361,11 +361,11 @@ static int ssm2518_hw_params(struct snd_pcm_substream *substream,
return -EINVAL;
if (ssm2518->right_j) {
- switch (params_format(params)) {
- case SNDRV_PCM_FORMAT_S16_LE:
+ switch (params_width(params)) {
+ case 16:
ctrl1 |= SSM2518_SAI_CTRL1_FMT_RJ_16BIT;
break;
- case SNDRV_PCM_FORMAT_S24_LE:
+ case 24:
ctrl1 |= SSM2518_SAI_CTRL1_FMT_RJ_24BIT;
break;
default:
--
2.0.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH 2/2] ASoC: ssm2602: Convert to params_width()
2014-07-31 12:18 [PATCH 1/2] ASoC: ssm2518: Convert to params_width() Mark Brown
@ 2014-07-31 12:18 ` Mark Brown
2014-07-31 12:20 ` Lars-Peter Clausen
2014-07-31 12:19 ` [PATCH 1/2] ASoC: ssm2518: " Lars-Peter Clausen
1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2014-07-31 12:18 UTC (permalink / raw)
To: Lars-Peter Clausen, Liam Girdwood; +Cc: alsa-devel, linaro-kernel, Mark Brown
From: Mark Brown <broonie@linaro.org>
The CODEC doesn't care how data is laid out in memory.
Signed-off-by: Mark Brown <broonie@linaro.org>
---
sound/soc/codecs/ssm2602.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/sound/soc/codecs/ssm2602.c b/sound/soc/codecs/ssm2602.c
index 97b0454eb346..484b3bbe8624 100644
--- a/sound/soc/codecs/ssm2602.c
+++ b/sound/soc/codecs/ssm2602.c
@@ -275,17 +275,17 @@ static int ssm2602_hw_params(struct snd_pcm_substream *substream,
regmap_write(ssm2602->regmap, SSM2602_SRATE, srate);
/* bit size */
- switch (params_format(params)) {
- case SNDRV_PCM_FORMAT_S16_LE:
+ switch (params_width(params)) {
+ case 16:
iface = 0x0;
break;
- case SNDRV_PCM_FORMAT_S20_3LE:
+ case 20:
iface = 0x4;
break;
- case SNDRV_PCM_FORMAT_S24_LE:
+ case 24:
iface = 0x8;
break;
- case SNDRV_PCM_FORMAT_S32_LE:
+ case 32:
iface = 0xc;
break;
default:
--
2.0.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH 2/2] ASoC: ssm2602: Convert to params_width()
2014-07-31 12:18 ` [PATCH 2/2] ASoC: ssm2602: " Mark Brown
@ 2014-07-31 12:20 ` Lars-Peter Clausen
0 siblings, 0 replies; 4+ messages in thread
From: Lars-Peter Clausen @ 2014-07-31 12:20 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, linaro-kernel, Mark Brown
On 07/31/2014 02:18 PM, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The CODEC doesn't care how data is laid out in memory.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
> ---
> sound/soc/codecs/ssm2602.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/codecs/ssm2602.c b/sound/soc/codecs/ssm2602.c
> index 97b0454eb346..484b3bbe8624 100644
> --- a/sound/soc/codecs/ssm2602.c
> +++ b/sound/soc/codecs/ssm2602.c
> @@ -275,17 +275,17 @@ static int ssm2602_hw_params(struct snd_pcm_substream *substream,
> regmap_write(ssm2602->regmap, SSM2602_SRATE, srate);
>
> /* bit size */
> - switch (params_format(params)) {
> - case SNDRV_PCM_FORMAT_S16_LE:
> + switch (params_width(params)) {
> + case 16:
> iface = 0x0;
> break;
> - case SNDRV_PCM_FORMAT_S20_3LE:
> + case 20:
> iface = 0x4;
> break;
> - case SNDRV_PCM_FORMAT_S24_LE:
> + case 24:
> iface = 0x8;
> break;
> - case SNDRV_PCM_FORMAT_S32_LE:
> + case 32:
> iface = 0xc;
> break;
> default:
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/2] ASoC: ssm2518: Convert to params_width()
2014-07-31 12:18 [PATCH 1/2] ASoC: ssm2518: Convert to params_width() Mark Brown
2014-07-31 12:18 ` [PATCH 2/2] ASoC: ssm2602: " Mark Brown
@ 2014-07-31 12:19 ` Lars-Peter Clausen
1 sibling, 0 replies; 4+ messages in thread
From: Lars-Peter Clausen @ 2014-07-31 12:19 UTC (permalink / raw)
To: Mark Brown, Liam Girdwood; +Cc: alsa-devel, linaro-kernel, Mark Brown
On 07/31/2014 02:18 PM, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The CODEC doesn't care how data is laid out in memory.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Thanks.
> ---
> sound/soc/codecs/ssm2518.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/ssm2518.c b/sound/soc/codecs/ssm2518.c
> index 56adb3e2def9..e8680bea5f86 100644
> --- a/sound/soc/codecs/ssm2518.c
> +++ b/sound/soc/codecs/ssm2518.c
> @@ -361,11 +361,11 @@ static int ssm2518_hw_params(struct snd_pcm_substream *substream,
> return -EINVAL;
>
> if (ssm2518->right_j) {
> - switch (params_format(params)) {
> - case SNDRV_PCM_FORMAT_S16_LE:
> + switch (params_width(params)) {
> + case 16:
> ctrl1 |= SSM2518_SAI_CTRL1_FMT_RJ_16BIT;
> break;
> - case SNDRV_PCM_FORMAT_S24_LE:
> + case 24:
> ctrl1 |= SSM2518_SAI_CTRL1_FMT_RJ_24BIT;
> break;
> default:
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-31 12:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-07-31 12:18 [PATCH 1/2] ASoC: ssm2518: Convert to params_width() Mark Brown
2014-07-31 12:18 ` [PATCH 2/2] ASoC: ssm2602: " Mark Brown
2014-07-31 12:20 ` Lars-Peter Clausen
2014-07-31 12:19 ` [PATCH 1/2] ASoC: ssm2518: " Lars-Peter Clausen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).