alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>, Liam Girdwood <lgirdwood@gmail.com>
Cc: alsa-devel@alsa-project.org, linaro-kernel@lists.linaro.org,
	Mark Brown <broonie@linaro.org>
Subject: Re: [PATCH 2/2] ASoC: ssm2602: Convert to params_width()
Date: Thu, 31 Jul 2014 14:20:06 +0200	[thread overview]
Message-ID: <53DA3476.4090209@metafoo.de> (raw)
In-Reply-To: <1406809099-18597-2-git-send-email-broonie@kernel.org>

On 07/31/2014 02:18 PM, Mark Brown wrote:
> From: Mark Brown <broonie@linaro.org>
>
> The CODEC doesn't care how data is laid out in memory.
>
> Signed-off-by: Mark Brown <broonie@linaro.org>

Acked-by: Lars-Peter Clausen <lars@metafoo.de>

Thanks.

> ---
>   sound/soc/codecs/ssm2602.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/sound/soc/codecs/ssm2602.c b/sound/soc/codecs/ssm2602.c
> index 97b0454eb346..484b3bbe8624 100644
> --- a/sound/soc/codecs/ssm2602.c
> +++ b/sound/soc/codecs/ssm2602.c
> @@ -275,17 +275,17 @@ static int ssm2602_hw_params(struct snd_pcm_substream *substream,
>   	regmap_write(ssm2602->regmap, SSM2602_SRATE, srate);
>
>   	/* bit size */
> -	switch (params_format(params)) {
> -	case SNDRV_PCM_FORMAT_S16_LE:
> +	switch (params_width(params)) {
> +	case 16:
>   		iface = 0x0;
>   		break;
> -	case SNDRV_PCM_FORMAT_S20_3LE:
> +	case 20:
>   		iface = 0x4;
>   		break;
> -	case SNDRV_PCM_FORMAT_S24_LE:
> +	case 24:
>   		iface = 0x8;
>   		break;
> -	case SNDRV_PCM_FORMAT_S32_LE:
> +	case 32:
>   		iface = 0xc;
>   		break;
>   	default:
>

  reply	other threads:[~2014-07-31 12:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-31 12:18 [PATCH 1/2] ASoC: ssm2518: Convert to params_width() Mark Brown
2014-07-31 12:18 ` [PATCH 2/2] ASoC: ssm2602: " Mark Brown
2014-07-31 12:20   ` Lars-Peter Clausen [this message]
2014-07-31 12:19 ` [PATCH 1/2] ASoC: ssm2518: " Lars-Peter Clausen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53DA3476.4090209@metafoo.de \
    --to=lars@metafoo.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=broonie@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linaro-kernel@lists.linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).