From: Clemens Ladisch <clemens@ladisch.de>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: alsa-devel@alsa-project.org, fenlason@redhat.com,
ffado-devel@lists.sf.net, linux1394-devel@lists.sourceforge.net
Subject: Re: [alsa-devel] [PATCH 12/15] oxfw: Add support for Behringer/Mackie devices
Date: Sun, 10 Aug 2014 17:54:45 +0200 [thread overview]
Message-ID: <53E795C5.1010506@ladisch.de> (raw)
In-Reply-To: <1399991272-5807-13-git-send-email-o-takashi@sakamocchi.jp>
Takashi Sakamoto wrote:
> Some devices produced by Behringer/Mackie are based on OXFW970/971. This
> commit adds support for them.
>
> +++ b/sound/firewire/oxfw/oxfw.c
> @@ -16,6 +16,8 @@
>
> #define VENDOR_GRIFFIN 0x001292
> #define VENDOR_LACIE 0x00d04b
> +#define VEN_BEHRINGER 0x001564
> +#define VEN_LOUD 0x000ff2
These IDs were supposed to be ordered. :)
And why "VEN_" instead of "VENDOR_"?
> + ...
> + {
> + .match_flags = IEEE1394_MATCH_VENDOR_ID |
> + IEEE1394_MATCH_MODEL_ID,
> + .vendor_id = VEN_LOUD,
> + .model_id = 0x000460,
> + },
> + /* IDs are unknown but able to be supported */
> + /* Mackie(Loud), d.2 pro */
> + /* Mackie(Loud), d.4 pro */
> + /* Mackie(Loud), U.420 */
> + /* Mackie(Loud), U.420d */
To support all Mackie devices, use one ID entry with only the vendor ID,
and abort with -ENODEV from the _probe function if the hardware is not
actually an OXFW97x device (try to read the HARDWARE_ID and/or
FIRMWARE_ID registers).
Regards,
Clemens
------------------------------------------------------------------------------
next prev parent reply other threads:[~2014-08-10 15:54 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-13 14:27 [RFC][PATCH 00/15 v4] OXFW driver, a succesor to firewire-speakers Takashi Sakamoto
2014-05-13 14:27 ` [PATCH 01/15] speakers: Rename to oxfw and rename some members Takashi Sakamoto
2014-05-13 14:27 ` [PATCH 02/15] oxfw: Move to its own directory Takashi Sakamoto
2014-05-13 14:27 ` [PATCH 03/15] oxfw: Split stream functionality to a new file and add a header file Takashi Sakamoto
2014-05-13 14:27 ` [PATCH 04/15] oxfw: Split PCM functionality to a new file Takashi Sakamoto
2014-05-13 14:27 ` [PATCH 05/15] oxfw: Split control " Takashi Sakamoto
2014-05-13 14:27 ` [PATCH 06/15] oxfw: Change the way to name card Takashi Sakamoto
2014-05-13 14:27 ` [PATCH 07/15] oxfw: Change the way to make PCM rules/constraints Takashi Sakamoto
2014-05-13 14:27 ` [PATCH 08/15] oxfw: Add proc interface for debugging purpose Takashi Sakamoto
2014-05-13 14:27 ` [PATCH 09/15] oxfw: Change the way to start stream Takashi Sakamoto
2014-05-13 14:27 ` [PATCH 10/15] oxfw: Add support for AV/C stream format command to get supported stream formation Takashi Sakamoto
2014-05-13 14:27 ` [PATCH 11/15] oxfw: Add a quirk for Griffin FireWave Takashi Sakamoto
2014-05-13 14:27 ` [PATCH 12/15] oxfw: Add support for Behringer/Mackie devices Takashi Sakamoto
2014-08-10 15:54 ` Clemens Ladisch [this message]
2014-08-11 23:48 ` Takashi Sakamoto
2014-08-12 7:33 ` [alsa-devel] " Clemens Ladisch
2014-08-12 23:21 ` Takashi Sakamoto
2014-08-13 6:41 ` Clemens Ladisch
2014-08-13 7:00 ` Takashi Sakamoto
2014-08-13 7:07 ` Clemens Ladisch
2014-08-13 7:57 ` Takashi Sakamoto
2014-05-13 14:27 ` [PATCH 13/15] oxfw: Add support AMDTP in-stream and PCM capture Takashi Sakamoto
2014-05-13 14:27 ` [PATCH 14/15] oxfw: Add support for capture/playback MIDI messages Takashi Sakamoto
2014-05-13 14:27 ` [PATCH 15/15] oxfw: Add hwdep interface Takashi Sakamoto
2014-05-13 17:43 ` [RFC][PATCH 00/15 v4] OXFW driver, a succesor to firewire-speakers Stefan Richter
2014-05-14 14:15 ` Takashi Sakamoto
2014-08-10 15:54 ` Clemens Ladisch
2014-08-11 23:55 ` Takashi Sakamoto
2014-08-12 7:09 ` Clemens Ladisch
2014-08-12 22:45 ` Takashi Sakamoto
2014-08-13 7:06 ` Clemens Ladisch
2014-08-13 22:55 ` Takashi Sakamoto
2014-10-16 14:31 ` Takashi Sakamoto
2014-10-26 12:00 ` Stefan Richter
2014-10-26 14:15 ` Takashi Sakamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53E795C5.1010506@ladisch.de \
--to=clemens@ladisch.de \
--cc=alsa-devel@alsa-project.org \
--cc=fenlason@redhat.com \
--cc=ffado-devel@lists.sf.net \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=o-takashi@sakamocchi.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox